Fix factory api video encoder bitrate and settings for video encoder instance.

app/services/settings/output/output-settings.ts

@@ -647,18 +647,18 @@ export class OutputSettingsService extends Service {
           'VodTrackIndex',
         );
 
-        return { ...advancedStreamSettings, twitchTrack };
+        return { ...advancedStreamSettings, twitchTrack } as IAdvancedStreamingOutputSettings;
       }
 
-      return advancedStreamSettings;
+      return advancedStreamSettings as IAdvancedStreamingOutputSettings;
     } else {
       return {
         videoEncoder,
         enforceServiceBitrate,
         useAdvanced,
         customEncSettings,
         enableTwitchVOD,
-      };
+      } as ISimpleStreamingOutputSettings;
     }
   }
 
@@ -806,14 +806,19 @@ export class OutputSettingsService extends Service {
     return this.settingsService.findSettingValue(output, 'Recording', 'RecAAudio') ?? 'ffmpeg_aac';
   }
 
-  getStreamingVideoEncoderSettings(): ISettings {
+  getStreamingVideoEncoderSettings(mode: TOutputSettingsMode): ISettings {
     const output = this.settingsService.state.Output.formData;
 
-    const bitrate = this.settingsService.findSettingValue(output, 'Streaming', 'VBitrate');
+    const bitrate =
+      this.settingsService.findSettingValue(output, 'Streaming', 'bitrate') ??
+      this.settingsService.findSettingValue(output, 'Streaming', 'VBitrate');
+
+    if (mode === 'Simple') {
+      return { bitrate };
+    }
 
     // TODO: these are only being fetched in advanced mode
     const rateControl = this.settingsService.findSettingValue(output, 'Streaming', 'rate_control');
-    // const bitrate = this.settingsService.findSettingValue(output, 'Streaming', 'bitrate');
     const keyintSec = this.settingsService.findSettingValue(output, 'Streaming', 'keyint_sec');
     const x264opts = this.settingsService.findSettingValue(output, 'Streaming', 'x264opts');
 

app/services/streaming/streaming.ts

@@ -2237,10 +2237,23 @@ export class StreamingService
         key === 'videoEncoder' &&
         (contextName !== 'enhancedBroadcasting' || isEnhancedBroadcastingContext)
       ) {
-        instance.videoEncoder = VideoEncoderFactory.create(
-          settings.videoEncoder,
-          `video-encoder-${type}-${contextName}`,
-        );
+        const encoderSettings =
+          type === 'streaming'
+            ? this.outputSettingsService.getStreamingVideoEncoderSettings(mode)
+            : undefined;
+
+        if (encoderSettings) {
+          instance.videoEncoder = VideoEncoderFactory.create(
+            settings.videoEncoder,
+            `video-encoder-${type}-${contextName}`,
+            encoderSettings,
+          );
+        } else {
+          instance.videoEncoder = VideoEncoderFactory.create(
+            settings.videoEncoder,
+            `video-encoder-${type}-${contextName}`,
+          );
+        }
 
         if (instance.videoEncoder.lastError) {
           console.error(

test/regular/recording.ts

@@ -99,7 +99,13 @@ async function validateRecordingFiles(
   waitForDisplayed('h1=Recordings');
 
   const numRecordings = await getNumElements('[data-test=filename]');
-  t.is(numRecordings, numFiles, 'All recordings show in history matches number of files recorded');
+  t.is(
+    numRecordings,
+    numFiles,
+    `All recordings from ${
+      advanced ? 'Advanced' : 'Simple'
+    } mode in history matches number of files recorded`,
+  );
 }
 
 /**