Fix factory api video encoder bitrate and settings for video encoder instance.#5831
Open
michelinewu wants to merge 22 commits intostagingfrom
Open
Fix factory api video encoder bitrate and settings for video encoder instance.#5831michelinewu wants to merge 22 commits intostagingfrom
michelinewu wants to merge 22 commits intostagingfrom
Conversation
michelinewu
requested review from
aleksandr-voitenko,
gettinToasty,
sandboxcoder and
wesrupert
aleksandr-voitenko
approved these changes
Apr 7, 2026
aleksandr-voitenko
approved these changes
Apr 8, 2026
Collaborator
aleksandr-voitenko
left a comment
aleksandr-voitenko
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding on the closed PR [Draft] Pass saved streaming encoder settings to Factory API video encoder
#5828, this correctly applies encoder bitrate and settings to the video encoder instance when recording.