Migrate to VLC based player to fix video decoding on Android 12 and older#228
Migrate to VLC based player to fix video decoding on Android 12 and older#228Renarde-dev wants to merge 17 commits intodevelopfrom
Conversation
|
24e9cfd Remove sharing intent from the package lock, when merging to develop it need to be double checked |
Need specific fix from image-share branch, does not compile !!!
24e9cfd to
445f199
Compare
|
Rebase on develop post merge |
|
Fix work on A12 and not bellow |
Flutter minor bump https://github.com/flutter/flutter/blob/master/CHANGELOG.md#3352 workmanager 0.8 -> 0.9.0+3 (explicit upgrade) https://pub.dev/packages/workmanager/changelog
Add a section about debugging in CONTRIBUTING.md
Add proguard rules, Pass modern minify args Ask gradle to shrink android resources Default to share libc++ lib Add vlc player as a dependency Remove experimental option android.jetifier.ignorelist=bcprov-jdk15on Since the toolchain is set to Java17 with a resolver it should be ok to remove it
|
Currently testing VLC player
A few issue are still left :
|
This player implementation support fullscreen with media controls and seekbar
|
Video is distorted when ended and rotated, restored when playing |
This commit does not check if the app works, in fact it simply remove chewie and video player from pubspec.yaml
|
The videos aren't loading for some reason Error LogsThe video is working when used in test environement outside of piwigo NG |
|
A refactor is underway to allow VLC player to work |
# Conflicts: # android/gradle.properties # android/settings.gradle.kts # pubspec.lock # pubspec.yaml
|
Video thumbnail during upload is broken Async issue |
Need to fix duration and size
|
Need to fix video metadata in
|
|
Unable to properly integrate vlc for now. |
|
For people tracking this PR the issue is related to VLC player is solid-software/flutter_vlc_player#546 and using 16Kb version doesn't work either. |

Some code as been ported from receive-image-share, may cause conflict down the line.
The player show a green/black screen when trying to play AV1 encoded video on Android 12L and older. Video seems to also display with corrupted images or only sound play.
There seems to be some bug report on https://pub.dev/packages/video_player but they are mostly ignored.
This PR aims to try https://pub.dev/packages/flutter_vlc_player to see if it fixes the issues.