Redesign select copy move modal#227
Merged
Renarde-dev merged 37 commits intodevelopfrom Oct 10, 2025
Merged
Conversation
Support sharing images from external apps
In groovy there is no need to cast to string but in kotlin you cast keystoreProperties["XXXX"] to String which fail on null, there is two solution force every user who want to contribute to have a keystore or allow nullable keystoreProperties. I went with the latter to limit contributor friction.
Changes : _fe_analyzer_shared 85.0.0 (86.0.0 available) > analyzer 7.7.1 (was 7.5.5) (8.0.0 available) characters 1.4.0 (1.4.1 available) > flutter_local_notifications 19.4.0 (was 19.3.0) > flutter_local_notifications_windows 1.0.2 (was 1.0.0) flutter_secure_storage_linux 1.2.3 (2.0.1 available) flutter_secure_storage_macos 3.1.3 (4.0.0 available) flutter_secure_storage_platform_interface 1.1.2 (2.0.1 available) flutter_secure_storage_web 1.2.1 (2.0.0 available) flutter_secure_storage_windows 3.1.2 (4.0.0 available) > gal 2.3.2 (was 2.3.1) > image_picker_android 0.8.12+24 (was 0.8.12+23) js 0.6.7 (0.7.2 available) leak_tracker 10.0.9 (11.0.1 available) leak_tracker_flutter_testing 3.0.9 (3.0.10 available) leak_tracker_testing 3.0.1 (3.0.2 available) material_color_utilities 0.11.1 (0.13.0 available) meta 1.16.0 (1.17.0 available) petitparser 6.1.0 (7.0.0 available) rxdart 0.27.7 (0.28.0 available) test_api 0.7.4 (0.7.7 available) > url_launcher 6.3.2 (was 6.3.1) vector_math 2.1.4 (2.2.0 available) > video_player_android 2.8.9 (was 2.8.7) > video_player_avfoundation 2.8.0 (was 2.7.2) > video_player_web 2.4.0 (was 2.3.5) vm_service 15.0.0 (15.0.2 available) > webview_flutter_android 4.8.2 (was 4.7.0) > webview_flutter_wkwebview 3.22.1 (was 3.22.0) workmanager 0.6.0 (0.8.0 available) xml 6.5.0 (6.6.0 available)
Changelog : https://pub.dev/packages/workmanager/changelog#080 We don't use any feature subjected to a breaking change so the upgrade only required testing.
AGP 8.10.1 -> 8.11.1 Koltin 2.0.21 -> 2.2.0 Grale 8.11 -> 8.13 Remove kotlin option in favor of java toolchain see : - https://docs.gradle.org/current/userguide/toolchains.html - https://docs.gradle.org/current/userguide/upgrading_version_7.html#kotlin_dsl_plugin_toolchains - https://docs.gradle.org/current/userguide/kotlin_dsl.html#sec:kotlin-dsl_plugin
This commit is meant to speedup 2.4.1 release and the modal will be changed in a later version.
Need to refactor child scaffold
Renarde-dev
changed the title
Collaborator
Author
|
Display only album index as a prefix to ease debugging, need to remove existing padding scaffold. |
Add support for sharing images from external apps - Build issues fixed by foojay resolve - New model in a future PR - Dependencies bump fixed white screen issue - workmanager update fixed notification issue
New Crowdin updates
Renarde-dev
changed the title
Collaborator
Author
|
Trying to implement this template 
|
Need to refactor child scaffold
Merge branch 'Redisgn-select-copy-move-modal' of github.com:Piwigo/piwigo-flutter-app into Redisgn-select-copy-move-modal
Collaborator
Author
|
Rebased on develop, planning on cherry picking utility commits from #228 |
Need specific fix from image-share branch, does not compile !!!
connectivity_plus > 7.0.0 font_awesome_flutter > 10.10.0 package_info_plus > 9.0.0 device_info_plus > 12.1.0 workmanager > 0.9.0+3 share_plus > 12.0.0 All changelogs state an AGB upgrade is required
Upgrades : - AGP to 8.13.0 - kotlin to 2.2.20 - AndroidX.window to 1.5.0 Removed jetifier since all dependencies have migrated to AndroidX tooling, this include remove whitelist for BouncyCastle Provider (bcprov-jdk15on) Android build and Flutter build are now faster by skipping jetifier warper
Add a section about debugging in CONTRIBUTING.md
- Kotlin now use compilerOptions -> jvmTarget - Gradle properties changed to use 8G of ram and removed kotlin specific limit - Bumped NDK
- Need to fix padding - Need to fix magic color number
Collaborator
Author
|
Wrong padding, looking for an icon that may fix it |
Renarde-dev
requested review from
LintyDev and
remi-martin
and removed request for
remi-martin
LintyDev
approved these changes
Oct 10, 2025
Draw Arbitrary number of spacing when index > 1
Collaborator
Author
|
May need to change it, keeping it as is for 2.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old modal design dots (
.) to differentiate between parent and children albums.This modal is supposed to handle moving/copying albums and photo and is also use by the new sharing feature.
It has been reworked without changing structure in #225 by adding indent through the text, but this is a stopgap.
The entire structure of the modal need to be changed to build a cleaner implementation.