Add Edit Terrain Location Module#751
Open
ampersand38 wants to merge 22 commits intozen-mod:masterfrom
Open
Conversation
mharis001
requested changes
Oct 8, 2023
was left over from I thought attributes might be conditional
mharis001
reviewed
Oct 8, 2023
mharis001
reviewed
Nov 17, 2023
Member
mharis001
left a comment
mharis001
left a comment
There was a problem hiding this comment.
Looks good. Just some style/cleanup suggestions.
Member
Author
|
I tried to use |
BrettMayson
approved these changes
Apr 6, 2026
Member
|
Does this work for JIP now? |
Member
Author
Yes =D on subsequent edits as well |
mharis001
requested changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: