Fix updating eglot-sever-programs when multiple java-related assocs e…#66
Open
heinzfridolin wants to merge 1 commit intoyveszoundi:mainfrom
Open
Fix updating eglot-sever-programs when multiple java-related assocs e…#66heinzfridolin wants to merge 1 commit intoyveszoundi:mainfrom
heinzfridolin wants to merge 1 commit intoyveszoundi:mainfrom
Conversation
|
FWIW I tried to use this branch but the problem described in #56 persisted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is the eglot-java--init function messes up eglot-server-programs when multiple java-related assocs exist.
For example when it contains two elements with a car of '(java-mode java-ts-mode) because the user previously used add-to-list, then the first one would become '(java-mode java-ts-mode java-mode java-ts-mode) and eventually even self reference and throw an error.
The problem is caused by mapcan which is destructive because of nconc.
Just altering the first match suffices anyways, so we can use cl-find-if instead.
In my case the error often had the effect of eglot-java seemingly initalizing but the eglot-java-eclipse-jdt server
not actually existing, so #56 might be fixed.