[robotpy] Run wpiformat on non-python files#8362
Open
pjreiniger wants to merge 11 commits intowpilibsuite:2027from
Open
[robotpy] Run wpiformat on non-python files#8362pjreiniger wants to merge 11 commits intowpilibsuite:2027from
wpiformat on non-python files#8362pjreiniger wants to merge 11 commits intowpilibsuite:2027from
Conversation
Member
|
Some of the include order issues can be resolved with tweaks to the .styleguide file, but that's all getting replaced in #8350 anyway. |
Contributor
Author
For python? Thats what I meant in reference to the import order mattering. I'm sure there is a way to disable the linter check anyway, but I figured it might be more acceptable to Dustin to just run it on these (I assume) not very frequently touched c++ files |
cf29d21 to
d0959f9
Compare
d0959f9 to
fa8baab
Compare
auscompgeek
reviewed
Dec 12, 2025
|
|
||
|
|
||
| #include "wpi/hal/HALBase.h" | ||
| #include <semiwrap_init.hal._wpiHal.hpp> |
Member
There was a problem hiding this comment.
I think for these since they're locally generated files they should probably be "" includes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline discussion makes it seem like @virtuald might not love this, but I figured I would at least make the PR. This turns the styleguide on for the non-python robotpy files. The overwhelming amount of changes were related to whitespace, followed by some IWYU for standard library headers.
Python files are excluded because I think import order matters for some of them, and some tests cases are currently just "make sure this can be imported".
I broke it down into a a couple of commits to make the changes more ovbious
#pragma once. This allows wpiformat to get further along in the processc-style castsandsingle arg constructors should be explicituse braces for one line if statementsand collapsing nested namespaces