Windows: Add hardening when renaming Phar during update

[swissspidy]

No description provided.

[github-actions]

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

• composer install: Install dependencies.
• composer test: Run the full test suite.
• composer phpcs: Check for code style violations.
• composer phpcbf: Automatically fix code style violations.
• composer phpunit: Run unit tests.
• composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
php/commands/src/CLI_Command.php	0.00%	13 Missing ⚠️

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request introduces Windows-specific logic for updating the WP-CLI PHAR file, utilizing a backup file during the rename process to avoid potential file locking issues. Feedback was provided to improve the robustness of the realpath() call, as it can return false and result in an empty string when cast; a suggestion was made to fall back to the original path and to ensure support for tilde expansion in home-relative paths.

[Copilot]

Pull request overview

This PR hardens wp cli update behavior on Windows by avoiding in-place overwrites of the running Phar and instead performing a safer rename/backup swap during self-update.

Changes:

• Resolve the temp Phar path with realpath() before replacement.
• On Windows, rename the existing Phar to a .bak, move the new Phar into place, and attempt cleanup of the backup.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.