Skip to content

fix: update avatar semantics to also keep testTags [WPB-14812]#4802

Open
saleniuk wants to merge 3 commits intodevelopfrom
fix/user-avatar-semantics
Open

fix: update avatar semantics to also keep testTags [WPB-14812]#4802
saleniuk wants to merge 3 commits intodevelopfrom
fix/user-avatar-semantics

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented May 8, 2026

https://wearezeta.atlassian.net/browse/WPB-14812


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After recent changes in semantics, testTags from UserProfileAvatar are no longer visible for tests.

Causes (Optional)

testTag is also part of semantics, so using clearAndSetSemantics on parent removes tags from children as well.

Solutions

Instead of clearAndSetSemantics use just semantics so that it reads all the children, then also let UserStatusIndicator to have its own content description so that it's being read as well.
The result is still similar, like that:

Profile picture {user-name}, {user-status}, button, double tap to open profile

Testing

How to Test

Open conversation with some messages, enable talkback, focus on the avatar of message sender.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants