fix: update avatar semantics to also keep testTags [WPB-14812]#4802
Open
fix: update avatar semantics to also keep testTags [WPB-14812]#4802
Conversation
|
yamilmedina
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-14812
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
After recent changes in semantics,
testTags fromUserProfileAvatarare no longer visible for tests.Causes (Optional)
testTagis also part of semantics, so usingclearAndSetSemanticson parent removes tags from children as well.Solutions
Instead of
clearAndSetSemanticsuse justsemanticsso that it reads all the children, then also letUserStatusIndicatorto have its own content description so that it's being read as well.The result is still similar, like that:
Testing
How to Test
Open conversation with some messages, enable talkback, focus on the avatar of message sender.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.