BEP-42: DHT security extension#53
Open
charlescharles wants to merge 1 commit intowebtorrent:masterfrom
Open
Conversation
| /** | ||
| * Add a DHT node to the routing table. | ||
| * Add a DHT node to the routing table unless the nodeID doesn't match | ||
| * their address and we're enforcing nodeID security. |
There was a problem hiding this comment.
If you read the enforcement section of BEP42 you will notice that it only mentions lookups, not routing table maintenance.
I.e. as written it does not to exclude nodes from the overlay itself, only ignores them as store-targets to avoid eclipse attacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://www.bittorrent.org/beps/bep_0042.html. this PR is just for review; it's definitely not complete.
some stuff to sort out:
socket.createSockethappens async and callingsocket.address()in the constructor causes an exception. setting the node ID insocket.on 'listening'is problematic because other stuff like_debugalso uses nodeId. is there another way to get the address?ipfield different from you think yours is -- libtorrent doesn't seem to do anything about this@feross