Ignore TextField max_length in model validation#1705
Open
ReinerBRO wants to merge 1 commit intovitalik:masterfrom
Open
Ignore TextField max_length in model validation#1705ReinerBRO wants to merge 1 commit intovitalik:masterfrom
ReinerBRO wants to merge 1 commit intovitalik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextField.max_lengthonly affects Django forms, not model/database validation.This PR stops ModelSchema generation from passing
max_lengththrough to Pydantic forTextField, so long text values are accepted again. I also added a regression test covering aTextField(max_length=5)instance serialized throughcreate_schema().Validation:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest -c /dev/null tests/test_orm_schemas.py -k "textfield_max_length_is_not_enforced or all_fields or default" -qPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest -c /dev/null tests/test_orm_schemas.py -qruff check ninja/orm/fields.py tests/test_orm_schemas.py