Add path_params to context in ParamModel resolve#1639
Open
nfd wants to merge 1 commit intovitalik:masterfrom
Open
Add path_params to context in ParamModel resolve#1639nfd wants to merge 1 commit intovitalik:masterfrom
nfd wants to merge 1 commit intovitalik:masterfrom
Conversation
Lokker29
reviewed
Jan 9, 2026
|
|
||
| @model_validator(mode="wrap") | ||
| def validate_item_id(cls, values, handler, info): | ||
| item_id = context["path_params"].get("item_id") |
|
I endorse the idea of the request. I need this feature time to time too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating, it's convenient to get
path_paramsas part of context. For example,PATCH /items/<item id>/might want to validate thatitem id, if supplied, references a record of a specific type. Obviously this could be done after validation, but it feels like it should be part of the validation process.This PR adds
path_paramsto the context for model validation.