Fix ModelSchema ignoring declared fields when using exclude#1631
Open
almazkun wants to merge 1 commit intovitalik:masterfrom
Open
Fix ModelSchema ignoring declared fields when using exclude#1631almazkun wants to merge 1 commit intovitalik:masterfrom
almazkun wants to merge 1 commit intovitalik:masterfrom
Conversation
vitalik
reviewed
Dec 26, 2025
|
|
||
| def _get_declared_fields(self, base_class: Type[Schema]) -> Set[str]: | ||
| # Extracts field names already declared in the base Schema class to prevent duplicates when generating model fields. | ||
| if not hasattr(self, "_annotation_cache"): |
Owner
There was a problem hiding this comment.
Hi @almazkun
is there a reason to cache declared fields here with _annotation_cache ?
Author
There was a problem hiding this comment.
@vitalik No real reason, just trying to skip the field check each time because it seems the schema is walked multiple times when it’s built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1630