ci: clang-tidy: workaround unsupported external clang-tidy config#4975
Merged
ci: clang-tidy: workaround unsupported external clang-tidy config#4975
Conversation
vpirogov
reviewed
Apr 8, 2026
995dc86 to
256fe10
Compare
vpirogov
reviewed
Apr 9, 2026
vpirogov
approved these changes
Apr 9, 2026
256fe10 to
dcc9d45
Compare
renato-arantes
approved these changes
Apr 9, 2026
dcc9d45 to
95ae69c
Compare
clang-tidy is parsing the config file of ComputeLibrary and throwing an error since the config option `AnalyzeTemporaryDtors` has been removed in clang-tidy >= 18. This workaround deletes this unwanted config file. Signed-off-by: Siddhartha Menon <siddhartha.menon@arm.com>
95ae69c to
9f73c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this clang-tidy can read the config of third-party projects which may be different or unsupported in our clang-tidy version.
See failing run here: https://github.com/uxlfoundation/oneDNN/actions/runs/24151058018/job/70477858732
(I included the offending commit for testing purposes. It will be removed after review).
After the fix:
The run now passes: https://github.com/uxlfoundation/oneDNN/actions/runs/24151996493/job/70481202258?pr=4975
@vpirogov