Skip to content

ci: clang-tidy: workaround unsupported external clang-tidy config#4975

Merged
Sqvid merged 1 commit intomainfrom
sqvid/fix-clang-tidy
Apr 9, 2026
Merged

ci: clang-tidy: workaround unsupported external clang-tidy config#4975
Sqvid merged 1 commit intomainfrom
sqvid/fix-clang-tidy

Conversation

@Sqvid
Copy link
Copy Markdown
Contributor

@Sqvid Sqvid commented Apr 8, 2026

Description

Without this clang-tidy can read the config of third-party projects which may be different or unsupported in our clang-tidy version.

See failing run here: https://github.com/uxlfoundation/oneDNN/actions/runs/24151058018/job/70477858732

(I included the offending commit for testing purposes. It will be removed after review).

...
clang-tidy-18 -p=./build /home/runner/work/oneDNN/oneDNN/oneDNN/src/cpu/aarch64/jit_uni_layer_normalization.cpp
/home/runner/work/oneDNN/oneDNN/ComputeLibrary/.clang-tidy:5:1: error: unknown key 'AnalyzeTemporaryDtors'
AnalyzeTemporaryDtors: false
^~~~~~~~~~~~~~~~~~~~~
...

After the fix:
The run now passes: https://github.com/uxlfoundation/oneDNN/actions/runs/24151996493/job/70481202258?pr=4975

...
clang-tidy-18 -p=./build --config-file=.clang-tidy /home/runner/work/oneDNN/oneDNN/oneDNN/src/cpu/aarch64/jit_uni_layer_normalization.cpp
3324 warnings generated.
Suppressed 3367 warnings (3324 in non-user code, 43 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
...

@vpirogov

@github-actions github-actions Bot added platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 devops Github automation component:common labels Apr 8, 2026
@Sqvid Sqvid marked this pull request as ready for review April 8, 2026 18:39
@Sqvid Sqvid requested review from a team as code owners April 8, 2026 18:39
Comment thread .github/workflows/clang-tidy.yml Outdated
@Sqvid Sqvid force-pushed the sqvid/fix-clang-tidy branch 2 times, most recently from 995dc86 to 256fe10 Compare April 9, 2026 12:09
@Sqvid Sqvid changed the title ci: clang-tidy: specify project's clang-tidy config ci: clang-tidy: workaround unsupported external clang-tidy config Apr 9, 2026
@Sqvid Sqvid requested a review from vpirogov April 9, 2026 12:18
Comment thread .github/workflows/clang-tidy.yml Outdated
@Sqvid Sqvid force-pushed the sqvid/fix-clang-tidy branch from 256fe10 to dcc9d45 Compare April 9, 2026 15:38
@github-actions github-actions Bot removed platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 component:common labels Apr 9, 2026
@Sqvid Sqvid force-pushed the sqvid/fix-clang-tidy branch from dcc9d45 to 95ae69c Compare April 9, 2026 15:50
@github-actions github-actions Bot added platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 component:common labels Apr 9, 2026
clang-tidy is parsing the config file of ComputeLibrary and throwing an
error since the config option `AnalyzeTemporaryDtors` has been removed
in clang-tidy >= 18. This workaround deletes this unwanted config file.

Signed-off-by: Siddhartha Menon <siddhartha.menon@arm.com>
@Sqvid Sqvid force-pushed the sqvid/fix-clang-tidy branch from 95ae69c to 9f73c70 Compare April 9, 2026 15:57
@github-actions github-actions Bot removed platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 component:common labels Apr 9, 2026
@Sqvid Sqvid merged commit f78a15e into main Apr 9, 2026
12 checks passed
@Sqvid Sqvid deleted the sqvid/fix-clang-tidy branch April 9, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Github automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants