Skip to content

Add buildSrc to tags task.#7632

Open
smillst wants to merge 1 commit intotypetools:masterfrom
smillst:tags
Open

Add buildSrc to tags task.#7632
smillst wants to merge 1 commit intotypetools:masterfrom
smillst:tags

Conversation

@smillst
Copy link
Copy Markdown
Member

@smillst smillst commented Apr 10, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

📝 Walkthrough

Walkthrough

The tags Gradle task in build.gradle was modified to change how the etags command is invoked. The modification adds buildSrc/TAGS an additional time at the end of the commandLine argument list. Previously, the TAGS files from multiple modules were included exactly once. This change results in buildSrc/TAGS being passed to etags twice. No changes were made to any exported or public entity signatures; only the internal command-line arguments of the task were altered.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@build.gradle`:
- Line 763: The etags invocation in the commandLine("etags", ...) call includes
the argument "-i", "buildSrc/TAGS" twice; remove the duplicate "-i",
"buildSrc/TAGS" entry from that commandLine invocation so each TAGS path is only
listed once (locate the commandLine("etags", ...) call and delete the redundant
"buildSrc/TAGS" pair).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 49cf72ac-8f6e-4103-8f25-7875990063e4

📥 Commits

Reviewing files that changed from the base of the PR and between 154601b and e54d555.

📒 Files selected for processing (1)
  • build.gradle

group = "Emacs"
// running this task will also run the tags task in the subprojects, which is defined later in this file.
commandLine("etags", "-i", "annotation-file-utilities/TAGS", "-i", "buildSrc/TAGS", "-i", "checker/TAGS", "-i", "checker-qual/TAGS", "-i", "checker-util/TAGS", "-i", "dataflow/TAGS", "-i", "framework/TAGS", "-i", "framework-test/TAGS", "-i", "javacutil/TAGS", "-i", "docs/manual/TAGS")
commandLine("etags", "-i", "annotation-file-utilities/TAGS", "-i", "buildSrc/TAGS", "-i", "checker/TAGS", "-i", "checker-qual/TAGS", "-i", "checker-util/TAGS", "-i", "dataflow/TAGS", "-i", "framework/TAGS", "-i", "framework-test/TAGS", "-i", "javacutil/TAGS", "-i", "docs/manual/TAGS", "-i", "buildSrc/TAGS")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove duplicated buildSrc/TAGS include from the etags command.

Line 763 passes "-i", "buildSrc/TAGS" twice, which is redundant and can lead to duplicate entries in TAGS output.

Suggested fix
-  commandLine("etags", "-i", "annotation-file-utilities/TAGS", "-i", "buildSrc/TAGS", "-i", "checker/TAGS", "-i", "checker-qual/TAGS", "-i", "checker-util/TAGS", "-i", "dataflow/TAGS", "-i", "framework/TAGS", "-i", "framework-test/TAGS", "-i", "javacutil/TAGS", "-i", "docs/manual/TAGS", "-i", "buildSrc/TAGS")
+  commandLine("etags", "-i", "annotation-file-utilities/TAGS", "-i", "buildSrc/TAGS", "-i", "checker/TAGS", "-i", "checker-qual/TAGS", "-i", "checker-util/TAGS", "-i", "dataflow/TAGS", "-i", "framework/TAGS", "-i", "framework-test/TAGS", "-i", "javacutil/TAGS", "-i", "docs/manual/TAGS")
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@build.gradle` at line 763, The etags invocation in the commandLine("etags",
...) call includes the argument "-i", "buildSrc/TAGS" twice; remove the
duplicate "-i", "buildSrc/TAGS" entry from that commandLine invocation so each
TAGS path is only listed once (locate the commandLine("etags", ...) call and
delete the redundant "buildSrc/TAGS" pair).

@mernst mernst assigned smillst and unassigned mernst Apr 10, 2026
@mernst
Copy link
Copy Markdown
Member

mernst commented Apr 10, 2026

The problem is that etags is never run within the buildSrc directory.
It could use a command like this:

rm -f TAGS; find . -type f -name '\''*.java'\'' -print0 | xargs -0 etags -a

though making it more uniform with the other subprojects would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants