Fix incompatible override of getRedirectData() in FetchTransactionResponse#90
Open
nfourtythree wants to merge 2 commits intothephpleague:masterfrom
Open
Fix incompatible override of getRedirectData() in FetchTransactionResponse#90nfourtythree wants to merge 2 commits intothephpleague:masterfrom
getRedirectData() in FetchTransactionResponse#90nfourtythree wants to merge 2 commits intothephpleague:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
FetchTransactionResponseis redeclaring thegetRedirectData()method and always returningnull.This return type does not match the documented and implemented return in Omnipay Common's
AbstractResponseSee here: https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Message/AbstractResponse.php#L179-L187
This PR fixes the issue by removing the redeclaration of the method in the class as the inherited implementation does everything that is required.