Add "exposed" operation for system nexus endpoint #736
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package nexus.v1; | ||
|
|
||
| import "google/protobuf/descriptor.proto"; | ||
|
|
||
| option go_package = "github.com/bergundy/nexus-proto-annotations/go/nexus/v1"; | ||
|
|
||
| extend google.protobuf.ServiceOptions { | ||
| optional ServiceOptions service = 8233; | ||
| } | ||
|
|
||
| extend google.protobuf.MethodOptions { | ||
| optional OperationOptions operation = 8234; | ||
| } | ||
|
|
||
| message OperationOptions { | ||
| // Nexus operation name (defaults to proto method name). | ||
| string name = 1; | ||
| // Tags to attach to the operation. Used by code generators to include and exclude operations. | ||
| repeated string tags = 2; | ||
| } | ||
|
|
||
| message ServiceOptions { | ||
|
Member
There was a problem hiding this comment. We have tags on services too but you didn't support excluding or including based on tags. That's fine for now, but the "official" plugin would need to have all of this functionality, similar to what |
||
| // Nexus service name (defaults to proto service full name). | ||
| string name = 1; | ||
| // Tags to attach to the service. Used by code generators to include and exclude services. | ||
| repeated string tags = 2; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name here would be different depending on the verdict of where we would want to put these annotations. I don't think we should reference anything in my personal repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that the annotations already exist in the referenced GH repo, I had to inline them here because the package name
nexuswas conflicting and confusing our protoc generation pipeline.