Skip to content

Fix pagination scroll behavior across website #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhavgupta5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pagination scroll behavior across website #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/www/app/(discover)/components/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ export function Pagination({ currentPage, totalPages, onPageChange, itemsPerPage
return pages
}

const handlePageChange = (page: number) => {
onPageChange(page)
window.scrollTo({ top: 0, behavior: 'smooth' })
}

const startItem = (currentPage - 1) * itemsPerPage + 1
const endItem = Math.min(currentPage * itemsPerPage, totalItems)

Expand Down Expand Up @@ -77,7 +82,7 @@ export function Pagination({ currentPage, totalPages, onPageChange, itemsPerPage
{totalPages > 1 && (
<div className="flex items-center gap-0.5">
<button
onClick={() => onPageChange(currentPage - 1)}
onClick={() => handlePageChange(currentPage - 1)}
disabled={currentPage === 1}
className="hover:bg-muted active:scale-98 flex h-7 w-9 items-center justify-center rounded-md transition-all disabled:cursor-not-allowed disabled:opacity-30"
aria-label="Previous page">
Expand All @@ -98,7 +103,7 @@ export function Pagination({ currentPage, totalPages, onPageChange, itemsPerPage
return (
<button
key={page}
onClick={() => onPageChange(page as number)}
onClick={() => handlePageChange(page as number)}
className={cn('active:scale-98 flex h-7 w-9 items-center justify-center rounded-md text-sm transition-all', currentPage === page ? 'bg-card ring-foreground/6.5 text-foreground font-medium shadow-md shadow-black/5 ring-1' : 'hover:bg-muted text-foreground')}
aria-label={`Page ${page}`}
aria-current={currentPage === page ? 'page' : undefined}>
Expand All @@ -108,7 +113,7 @@ export function Pagination({ currentPage, totalPages, onPageChange, itemsPerPage
})}

<button
onClick={() => onPageChange(currentPage + 1)}
onClick={() => handlePageChange(currentPage + 1)}
disabled={currentPage === totalPages}
className="hover:bg-muted active:scale-98 flex h-7 w-9 items-center justify-center rounded-md transition-all disabled:cursor-not-allowed disabled:opacity-30"
aria-label="Next page">
Expand Down