fix: add missing textMsg and errorMsg mocks to help.test.js#6538
Closed
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Closed
fix: add missing textMsg and errorMsg mocks to help.test.js#6538AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Conversation
github-actions
Bot
added
bug fix
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
mahesh-09-12
approved these changes
Apr 11, 2026
Contributor
mahesh-09-12
left a comment
mahesh-09-12
left a comment
There was a problem hiding this comment.
Adding the missing mocks makes sense and aligns with the test setup.
Looks good to me.
Ashutoshx7
approved these changes
Apr 11, 2026
Member
|
Not sure why we need errorMsg. textMsg was added in #6543 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
help.test.js was failing on master. The createMockActivity function was
missing textMsg and errorMsg, causing a TypeError when the onclose handler
was triggered.
All 39 tests pass after this fix.
PR Category