feat: Improve keyboard focus visibility for accessibility#6448
feat: Improve keyboard focus visibility for accessibility#6448abdulazees1111s wants to merge 5 commits intosugarlabs:masterfrom
Conversation
|
Hi! I created a PR to improve keyboard focus visibility for accessibility. Could someone review it? Thanks! |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
kartikktripathi
left a comment
There was a problem hiding this comment.
This seems to have a lot of unrelated changes. Please check and remove them before a maintainer takes a look.
vanshika2720
left a comment
There was a problem hiding this comment.
@abdulazees1111s Please split this PR into smaller ones:
PR 1: Accessibility (focus styles only)
PR 2: Tamil + language additions
PR 3: Translation updates (ta.json)
PR 4 (optional): Toolbar cleanup
|
any updates on this ? |
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
|
Merge conflicts resolved. Ready for review. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
toolbar jest still faling take a look |
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
zealot-zew
left a comment
There was a problem hiding this comment.
lot of unrelated changes. and i believe we have keyboard focus visibility on master.
@walterbender This PR can be closed now
|
Please reopen as smaller, targeted PRs |
Summary
Improved keyboard focus visibility across UI components to enhance accessibility.
Changes Made
Accessibility
Improves usability for keyboard users and users with accessibility needs.
Testing
PR Category