Fix: Improve palette text contrast across light, dark, and high-contrast themesFix palette text contrast#6440
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hi! This is my first contribution. I’ve addressed the UI contrast issue across themes. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
hey, i think this is totally different problem. the inconsistency happens sometimes when it doesn't load properly, but right now the in the master it works good. |
|
hey @abdulazees1111s , Thanks for the accessibility improvements ... I noticed a few things that should be addressed before merging this :
Once these are sorted out, I’d feel much more comfortable approving the PR. |
|
hy take a look everything is faling can't start reviewing at this stage |
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
Summary
Improved text visibility and contrast for palette items across light, dark, and high-contrast themes.
Problem
Palette items (e.g., "Flow") had poor contrast in different themes:
This made the UI difficult to read and reduced accessibility.
Changes Made
Updated text color for palette items to ensure sufficient contrast
Improved background color for hover and selected states
Added theme-specific styling for:
Ensured consistent readability across all modes
Accessibility
These changes improve usability for users with:
Testing
Screenshots
** Before
**After
1.Light Mode
2.Dark Mode
3.High Contrast Mode
Issue
Fixes #6439
PR Category