Clear server/key when enabling/disabling protected mode#5827
Open
mhoyer-streamlabs wants to merge 2 commits intomasterfrom
Open
Clear server/key when enabling/disabling protected mode#5827mhoyer-streamlabs wants to merge 2 commits intomasterfrom
mhoyer-streamlabs wants to merge 2 commits intomasterfrom
Conversation
22eb129 to
6557d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user switches to
Recommended Settings, they key is cleared but the server also needs to be cleared (service is automatically cleared when the stream type changes); uncleared previous settings can cause incorrect information to be displayed/used.One scenario:
Streamsettings, go toCustom IngestThe same issue exists for both enabling and disabling protected mode (
Recommended SettingsvsCustom Ingest), so clear the fields in both cases.Incorrect settings displayed: