Return row objects directly in listRedirects

Author: john-shaffer

src/CrawledFiles.php

@@ -368,7 +368,7 @@ public static function getTotal(): int {
     }
 
     /**
-     * @return mixed[] redirects
+     * @return object[] redirects
      */
     public static function listRedirects(): array {
         global $wpdb;
@@ -379,14 +379,6 @@ public static function listRedirects(): array {
             "SELECT path, redirect_to FROM $table_name WHERE 0 < LENGTH(redirect_to)"
         );
 
-        $redirs = [];
-        foreach ( $rows as $row ) {
-            $redirs[ $row->path ] = [
-                'url' => $row->path,
-                'redirect_to' => $row->redirect_to,
-            ];
-        }
-
-        return $redirs;
+        return $rows;
     }
 }

src/S3/Deployer.php

@@ -90,15 +90,15 @@ public function uploadFiles( string $processed_site_path ): void {
             }
 
             foreach ( $redirects as $redirect ) {
-                $path = $redirect['url'];
+                $path = $redirect->path;
 
                 if ( mb_substr( $path, -1 ) === '/' ) {
                     $path = $path . 'index.html';
                 }
 
                 yield [
                     'path' => $path,
-                    'redirect_to' => $redirect['redirect_to'],
+                    'redirect_to' => $redirect->redirect_to,
                 ];
             }
         };