Replace list_redirects filter with a function call

Author: john-shaffer

src/CrawledFiles.php

@@ -368,10 +368,9 @@ public static function getTotal(): int {
     }
 
     /**
-     * @param mixed[] $redirs
      * @return mixed[] redirects
      */
-    public static function wp2static_list_redirects( array $redirs ): array {
+    public static function listRedirects(): array {
         global $wpdb;
 
         $table_name = self::getTableName();
@@ -380,6 +379,7 @@ public static function wp2static_list_redirects( array $redirs ): array {
             "SELECT path, redirect_to FROM $table_name WHERE 0 < LENGTH(redirect_to)"
         );
 
+        $redirs = [];
         foreach ( $rows as $row ) {
             $redirs[ $row->path ] = [
                 'url' => $row->path,

src/S3/Deployer.php

@@ -9,6 +9,7 @@
 use Aws\Credentials\Credentials;
 use Aws\Exception\AwsException;
 use Aws\S3\S3Client;
+use WP2Static\CrawledFiles;
 use WP2Static\Options;
 use WP2Static\WsLog;
 
@@ -102,7 +103,7 @@ public function uploadFiles( string $processed_site_path ): void {
             }
         };
 
-        $redirects = apply_filters( 'wp2static_list_redirects', [] );
+        $redirects = CrawledFiles::listRedirects();
 
         self::uploadFilesIter( $file_arrays( $files, $redirects ) );
     }

src/WordPressAdmin.php

@@ -55,11 +55,6 @@ public static function registerHooks( string $bootstrap_file ): void {
             [ WPCron::class, 'wp2static_custom_cron_schedules' ]
         );
 
-        add_filter(
-            Controller::getHookName( 'list_redirects' ),
-            [ CrawledFiles::class, 'wp2static_list_redirects' ]
-        );
-
         add_filter(
             'cron_request',
             [ WPCron::class, 'wp2static_cron_with_http_basic_auth' ]