feat(sfs): Refactor wait handler to use new WaiterHelper#7231
Open
j1n-o9r wants to merge 7 commits into
Open
Conversation
185defd to
4d4e5e6
Compare
21b2b7f to
4d4e5e6
Compare
…alue in error case to empty string to align to new waitHelper concept
1a26fa5 to
e545a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the wait handler of sfs, to use the new WaiterHelper struct. Replace every possible wait handler implementation of this service, to use just the WaiterHelper.
relates to STACKITSDK-368
Testing Instruction
checkout feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper
run
make testgo to your terraform repo and add this line to go mod, adjust path to sdk if necessary
replace github.com/stackitcloud/stackit-sdk-go/services/sfs => ../stackit-sdk-go/services/sfsrun tf acceptance tests for sfs
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)