Skip to content

feat(sfs): Refactor wait handler to use new WaiterHelper#7231

Open
j1n-o9r wants to merge 7 commits into
mainfrom
feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper
Open

feat(sfs): Refactor wait handler to use new WaiterHelper#7231
j1n-o9r wants to merge 7 commits into
mainfrom
feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper

Conversation

@j1n-o9r
Copy link
Copy Markdown

@j1n-o9r j1n-o9r commented May 11, 2026

Description

Update the wait handler of sfs, to use the new WaiterHelper struct. Replace every possible wait handler implementation of this service, to use just the WaiterHelper.

relates to STACKITSDK-368

Testing Instruction

  • checkout feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper

  • run make test

  • go to your terraform repo and add this line to go mod, adjust path to sdk if necessary
       replace github.com/stackitcloud/stackit-sdk-go/services/sfs => ../stackit-sdk-go/services/sfs

  • run tf acceptance tests for sfs

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch from 185defd to 4d4e5e6 Compare May 13, 2026 10:00
@j1n-o9r j1n-o9r marked this pull request as ready for review May 13, 2026 10:21
@j1n-o9r j1n-o9r requested a review from a team as a code owner May 13, 2026 10:22
@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch 2 times, most recently from 21b2b7f to 4d4e5e6 Compare May 13, 2026 10:49
@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch from 1a26fa5 to e545a8d Compare May 13, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant