chore: Use context.Context from InvocationContext by PeterSchafer · Pull Request #578 · snyk/go-application-framework

PeterSchafer · 2026-03-30T17:05:31Z

Description

This PR includes a couple of refactorings to make use of the context.Context instance provided by the InvocationContext. This requires extending a couple of interfaces.

To keep the changes incremental, it doesn't yet fully use the context and needs to fallback to context.Background() where the context is not directly available yet.

Checklist

Tests added and all succeed (make test)
Regenerated mocks, etc. (make generate)
Linted (make lint)
Test your changes work for the CLI
1. Clone / pull the latest CLI main.
2. Run go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMIT in the cliv2 directory.
  - Tip: for local testing, you can uncomment the line near the bottom of the CLI's go.mod to point to your local GAF code.
3. Run go mod tidy in the cliv2 directory.
4. Run the CLI tests and do any required manual testing.
5. Open a PR in the CLI repo now with the go.mod and go.sum changes.
- Once this PR is merged, repeat these steps, but pointing to the latest GAF commit on main and update your CLI PR.

snyk-io · 2026-03-30T17:05:44Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

snyk-io · 2026-03-30T17:05:44Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

danskmt · 2026-04-20T12:36:21Z

-		settings, err := apiClient.GetOrgSettings(org)
+		settings, err := apiClient.GetOrgSettings(context.Background(), org)
 		if err != nil {


Some places are using invocationCtx.Context() and others context.Background(). I also see the latter was replaced by the former in some cases.
What is the difference between them? Should we have a unified way of having the context?

snyk-pr-review-bot · 2026-04-21T07:21:09Z

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Workflow Cancellation Impact 🟡 [minor] Switching from `context.Background()` to `invocation.Context()` for semaphore acquisition means that if a workflow is terminated (e.g., via SIGINT), the rendering process will stop immediately. While usually desirable, this may lead to partial or missing output files if multiple writers are configured, as the loop breaks upon the first failed acquisition. Downstream consumers should be aware that output might be truncated on cancellation. ctx := invocation.Context() availableThreads := semaphore.NewWeighted(threadCount) for k, v := range writerMap { err = availableThreads.Acquire(ctx, 1) if err != nil {
📚 Repository Context Analyzed This review considered 47 relevant code sections from 13 files (average relevance: 0.98) pkg/mocks/workflow.go (3 segments, lines 1-238) pkg/local_workflows/connectivity_check_extension/connectivity_check_workflow.go (lines 1-97) pkg/apiclients/ldx_sync_config/mocks/ldx_sync.go (lines 1-180) pkg/apiclients/feature_flag_gateway/client.go (lines 1-62) pkg/local_workflows/output_workflow/other_tools.go (lines 1-144) pkg/local_workflows/data_transformation_workflow.go (lines 1-125) pkg/apiclients/ldx_sync_config/ldx_sync/2024-10-15/ldx_sync.go (lines 1-223) ... and 6 more file(s)

bastiandoetsch · 2026-04-21T08:19:29Z


 func getDefaultOrganization(apiClient api.ApiClient, logger *zerolog.Logger) (Organization, error) {
-	defaultOrgId, err := apiClient.GetDefaultOrgId()
+	defaultOrgId, err := apiClient.GetDefaultOrgId(context.Background())


don't like using background. better: a time-bound deadline context that is based on an app-wide context.

bastiandoetsch · 2026-04-21T08:20:01Z

 			return existingValue, nil
 		}
-		slugName, err := apiClient.GetSlugFromOrgId(orgId)
+		slugName, err := apiClient.GetSlugFromOrgId(context.Background(), orgId)


bastiandoetsch · 2026-04-21T08:20:41Z

 	org := config.GetString(configuration.ORGANIZATION)
 	apiClient := api.NewApi(url, httpClient)
-	result, err := apiClient.GetFeatureFlag(featureFlagName, org)
+	result, err := apiClient.GetFeatureFlag(context.Background(), featureFlagName, org)


bastiandoetsch · 2026-04-21T08:21:03Z

 	}

-	response, err := c.apiClient.GetOrganizations(limit)
+	response, err := c.apiClient.GetOrganizations(context.Background(), limit)


PeterSchafer requested review from a team as code owners March 30, 2026 17:05