Fix LT-21889: Add Find and Fix step for removing disowned children#372
Merged
jtmaxwell3 merged 2 commits intomasterfrom May 4, 2026
Merged
Fix LT-21889: Add Find and Fix step for removing disowned children#372jtmaxwell3 merged 2 commits intomasterfrom
jtmaxwell3 merged 2 commits intomasterfrom
Conversation
Contributor
|
The added assert for the error message is good, but we should also have a new assert for the actual data being removed. I expected to see an assert below in the |
jasonleenaylor
approved these changes
May 4, 2026
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor partially reviewed 6 files and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-21889. If the owner and stored owner don't match and the owner exists and the stored owner doesn't exist then the node has been disowned. This revealed some problems with the unit tests (type="o" instead of t="o").
This change is