Skip to content

Fix DpdkDeviceList not publicly inheriting DeviceListBase.#2102

Merged
Dimi1010 merged 1 commit intoseladb:devfrom
Dimi1010:fix/dpdk-base-list
Apr 14, 2026
Merged

Fix DpdkDeviceList not publicly inheriting DeviceListBase.#2102
Dimi1010 merged 1 commit intoseladb:devfrom
Dimi1010:fix/dpdk-base-list

Conversation

@Dimi1010
Copy link
Copy Markdown
Collaborator

Fixes DpdkDeviceList not publicly inheriting DeviceListBase like other device list classes to allow common device list functionalities like iteration over all devices.

@Dimi1010 Dimi1010 requested a review from seladb as a code owner April 13, 2026 07:34
@Dimi1010 Dimi1010 added the bug label Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.93%. Comparing base (718ae23) to head (a6a4ea9).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2102   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files         316      316           
  Lines       57024    57017    -7     
  Branches    11790    11777   -13     
=======================================
- Hits        47863    47858    -5     
+ Misses       8006     8001    -5     
- Partials     1155     1158    +3     
Flag Coverage Δ
alpine320 76.63% <ø> (-0.01%) ⬇️
fedora42 76.19% <ø> (-0.01%) ⬇️
macos-14 82.02% <ø> (-0.01%) ⬇️
macos-15 82.02% <ø> (ø)
mingw32 70.72% <ø> (-0.02%) ⬇️
mingw64 70.71% <ø> (+0.08%) ⬆️
npcap ?
rhel94 76.01% <ø> (-0.03%) ⬇️
ubuntu2004 59.74% <ø> (-0.03%) ⬇️
ubuntu2004-zstd 59.85% <ø> (ø)
ubuntu2204 76.01% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 59.10% <ø> (ø)
ubuntu2404 76.30% <ø> (-0.03%) ⬇️
ubuntu2404-arm64 76.33% <ø> (-0.01%) ⬇️
unittest 83.93% <ø> (+<0.01%) ⬆️
windows-2022 85.56% <ø> (+0.10%) ⬆️
windows-2025 85.61% <ø> (+0.11%) ⬆️
winpcap 85.61% <ø> (-0.09%) ⬇️
xdp 52.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010
Copy link
Copy Markdown
Collaborator Author

What's with the XDP CI failing tests half the time on unrelated changes? :/

Copy link
Copy Markdown
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dimi1010 Dimi1010 merged commit 12524f2 into seladb:dev Apr 14, 2026
114 of 116 checks passed
@Dimi1010 Dimi1010 deleted the fix/dpdk-base-list branch April 14, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants