Fix silent cast of ProtocolTypeFamily to ProtocolType in Packet ctor.#2099
Open
Dimi1010 wants to merge 2 commits intoseladb:devfrom
Open
Fix silent cast of ProtocolTypeFamily to ProtocolType in Packet ctor.#2099Dimi1010 wants to merge 2 commits intoseladb:devfrom
ProtocolTypeFamily to ProtocolType in Packet ctor.#2099Dimi1010 wants to merge 2 commits intoseladb:devfrom
Conversation
Dimi1010
changed the title
ProtocolTypeFamily to ProtocolType in Packet ctor.ProtocolTypeFamily to ProtocolType in Packet ctor.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2099 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 316 316
Lines 57024 57021 -3
Branches 11797 11794 -3
=======================================
- Hits 47863 47861 -2
- Misses 7941 7995 +54
+ Partials 1220 1165 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
reviewed
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of the full Packet parsing constructor to use
ProtocolTypeFamilyinstead ofProtocolType.This is done to allow protocol "family" constants to be used in the main signature. Previously used family constants (
uint32_t) were silently narrowed to the first protocol of the family (uint8_t). (e.g "IP" family would be treated as only "IPv4") if used in the full constructor signature.