Conversation
# Conflicts: # packages/jaspr/lib/src/browser/browser_binding.dart # packages/jaspr/lib/src/browser/clients.dart # packages/jaspr/lib/src/browser/js_data.dart # packages/jaspr/lib/src/foundation/sync.dart # packages/jaspr/lib/src/framework/render_element.dart # packages/jaspr/lib/src/server/document/document.dart # packages/jaspr/lib/src/server/document/document_base.dart # packages/jaspr/lib/src/server/document/document_binding.dart # packages/jaspr/lib/src/server/document/document_file.dart # packages/jaspr/lib/src/server/markup_renderer.dart # packages/jaspr_builder/lib/src/client/client_part_builder.dart
# Conflicts: # packages/jaspr/lib/src/browser/clients.dart # packages/jaspr_builder/lib/src/client/client_module_builder.dart
# Conflicts: # packages/jaspr/lib/browser.dart # packages/jaspr/lib/src/browser/clients.dart # packages/jaspr/lib/src/components/raw_text/raw_text_web.dart # packages/jaspr/lib/src/foundation/options.dart # packages/jaspr/lib/src/server/adapters/client_component_adapter.dart # packages/jaspr/lib/src/server/adapters/client_script_adapter.dart # packages/jaspr/lib/src/server/adapters/sync_script_adapter.dart # packages/jaspr/lib/src/server/server_binding.dart # packages/jaspr_builder/lib/src/client/client_module_builder.dart # packages/jaspr_builder/lib/src/client/client_registry_builder.dart
# Conflicts: # packages/jaspr/lib/src/browser/clients.dart # packages/jaspr/lib/src/components/raw_text/raw_text_web.dart # packages/jaspr/lib/src/foundation/marker_utils.dart # packages/jaspr/lib/src/foundation/options.dart # packages/jaspr/lib/src/server/adapters/client_component_adapter.dart # packages/jaspr/lib/src/server/adapters/client_script_adapter.dart # packages/jaspr/lib/src/server/server_binding.dart # packages/jaspr/test/browser/hydration/hydration_browser_test.dart # packages/jaspr_builder/lib/src/client/client_module_builder.dart # packages/jaspr_builder/lib/src/codec/codecs.dart
# Conflicts: # packages/jaspr/lib/src/browser/clients.dart # packages/jaspr/lib/src/client/custom_node_component.dart # packages/jaspr/lib/src/dom/raw_text/raw_text_web.dart # packages/jaspr/lib/src/foundation/options.dart # packages/jaspr/lib/src/server/adapters/client_component_adapter.dart # packages/jaspr/lib/src/server/adapters/client_script_adapter.dart # packages/jaspr/lib/src/server/server_binding.dart # packages/jaspr/test/client/hydration/hydration_browser_test.dart # packages/jaspr_builder/lib/src/client/client_module_builder.dart # packages/jaspr_builder/lib/src/codec/codec_module_builder.dart # packages/jaspr_builder/test/client/sources/client_basic.dart # packages/jaspr_builder/test/client/sources/client_model_class.dart # packages/jaspr_builder/test/client/sources/client_model_extension.dart # packages/jaspr_builder/test/sync/sources/sync_model_class.dart # packages/jaspr_builder/test/sync/sources/sync_model_extension.dart
# Conflicts: # packages/jaspr/lib/src/client/component_anchors.dart # packages/jaspr/lib/src/server/adapters/client_component_adapter.dart # packages/jaspr/lib/src/server/server_binding.dart # packages/jaspr_builder/lib/src/client/client_module_builder.dart # packages/jaspr_builder/lib/src/codec/codecs.dart # packages/jaspr_builder/lib/src/sync/sync_mixins_builder.dart # packages/jaspr_builder/test/client/sources/bundle.dart # packages/jaspr_builder/test/client/sources/client_basic.dart # packages/jaspr_builder/test/client/sources/client_model_class.dart # packages/jaspr_builder/test/client/sources/client_model_extension.dart # packages/jaspr_builder/test/codec/sources/bundle.dart # packages/jaspr_builder/test/codec/sources/model_class.dart # packages/jaspr_builder/test/codec/sources/model_extension.dart # packages/jaspr_builder/test/sync/sources/sync_basic.dart # packages/jaspr_builder/test/sync/sources/sync_multi.dart
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 60.82% 60.25% -0.57%
==========================================
Files 196 198 +2
Lines 11188 11429 +241
==========================================
+ Hits 6805 6887 +82
- Misses 4383 4542 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parlough
left a comment
There was a problem hiding this comment.
Exciting!! I haven't tried it out yet, but some small questions and a few minor suggestions to consider:
| for (var i = 0; i < _adapters.length; i++) { | ||
| final r = _adapters[i].prepare(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Can't use foreach because new adapters can be added during .prepare(). I will add a comment.
| rootRenderObject.node = newNode; | ||
| rootRenderObject.toHydrate = [...newNode.childNodes.toIterable()]; |
There was a problem hiding this comment.
Maybe encapsulate this logic in a new method on RootDomRenderObject, so node doesn't need to have a public setter.
There was a problem hiding this comment.
Done. Also I noticed I could remove some dead code in RootDomRenderObject.
|
|
||
| /// Reloads the current page. | ||
| void reload([String? path]) { | ||
| throw UnimplementedError('Should be overridden on client and server.'); |
There was a problem hiding this comment.
It seems the client's AppContext extension doesn't have this method. Is that intended?
There was a problem hiding this comment.
Ah no, that is leftover from I feature I was experimenting with but decided against for the initial version of server components. Will remove.
| } else if (allowComponent && | ||
| type.element.name == 'Component' && | ||
| type.element.library.identifier == 'package:jaspr/src/framework/framework.dart') { | ||
| return (decoder: 'p.mount($argument)', cast: 'String'); |
There was a problem hiding this comment.
What if the component parameter is nullable? Should this consider the nullability suffix like the above handling?
38c987f to
e46ec38
Compare
Description
Add support for Server Components to Jaspr.
Type of Change