Skip to content

[WIP] Server Components#776

Draft
schultek wants to merge 22 commits intomainfrom
feat/server-components
Draft

[WIP] Server Components#776
schultek wants to merge 22 commits intomainfrom
feat/server-components

Conversation

@schultek
Copy link
Copy Markdown
Owner

Description

Add support for Server Components to Jaspr.

Type of Change

  • ❌ Breaking change
  • ✨ New feature or improvement

Kilian Schulte and others added 21 commits June 14, 2024 16:39
# Conflicts:
#	packages/jaspr/lib/src/browser/browser_binding.dart
#	packages/jaspr/lib/src/browser/clients.dart
#	packages/jaspr/lib/src/browser/js_data.dart
#	packages/jaspr/lib/src/foundation/sync.dart
#	packages/jaspr/lib/src/framework/render_element.dart
#	packages/jaspr/lib/src/server/document/document.dart
#	packages/jaspr/lib/src/server/document/document_base.dart
#	packages/jaspr/lib/src/server/document/document_binding.dart
#	packages/jaspr/lib/src/server/document/document_file.dart
#	packages/jaspr/lib/src/server/markup_renderer.dart
#	packages/jaspr_builder/lib/src/client/client_part_builder.dart
# Conflicts:
#	packages/jaspr/lib/src/browser/clients.dart
#	packages/jaspr_builder/lib/src/client/client_module_builder.dart
# Conflicts:
#	packages/jaspr/lib/browser.dart
#	packages/jaspr/lib/src/browser/clients.dart
#	packages/jaspr/lib/src/components/raw_text/raw_text_web.dart
#	packages/jaspr/lib/src/foundation/options.dart
#	packages/jaspr/lib/src/server/adapters/client_component_adapter.dart
#	packages/jaspr/lib/src/server/adapters/client_script_adapter.dart
#	packages/jaspr/lib/src/server/adapters/sync_script_adapter.dart
#	packages/jaspr/lib/src/server/server_binding.dart
#	packages/jaspr_builder/lib/src/client/client_module_builder.dart
#	packages/jaspr_builder/lib/src/client/client_registry_builder.dart
# Conflicts:
#	packages/jaspr/lib/src/browser/clients.dart
#	packages/jaspr/lib/src/components/raw_text/raw_text_web.dart
#	packages/jaspr/lib/src/foundation/marker_utils.dart
#	packages/jaspr/lib/src/foundation/options.dart
#	packages/jaspr/lib/src/server/adapters/client_component_adapter.dart
#	packages/jaspr/lib/src/server/adapters/client_script_adapter.dart
#	packages/jaspr/lib/src/server/server_binding.dart
#	packages/jaspr/test/browser/hydration/hydration_browser_test.dart
#	packages/jaspr_builder/lib/src/client/client_module_builder.dart
#	packages/jaspr_builder/lib/src/codec/codecs.dart
# Conflicts:
#	packages/jaspr/lib/src/browser/clients.dart
#	packages/jaspr/lib/src/client/custom_node_component.dart
#	packages/jaspr/lib/src/dom/raw_text/raw_text_web.dart
#	packages/jaspr/lib/src/foundation/options.dart
#	packages/jaspr/lib/src/server/adapters/client_component_adapter.dart
#	packages/jaspr/lib/src/server/adapters/client_script_adapter.dart
#	packages/jaspr/lib/src/server/server_binding.dart
#	packages/jaspr/test/client/hydration/hydration_browser_test.dart
#	packages/jaspr_builder/lib/src/client/client_module_builder.dart
#	packages/jaspr_builder/lib/src/codec/codec_module_builder.dart
#	packages/jaspr_builder/test/client/sources/client_basic.dart
#	packages/jaspr_builder/test/client/sources/client_model_class.dart
#	packages/jaspr_builder/test/client/sources/client_model_extension.dart
#	packages/jaspr_builder/test/sync/sources/sync_model_class.dart
#	packages/jaspr_builder/test/sync/sources/sync_model_extension.dart
# Conflicts:
#	packages/jaspr/lib/src/client/component_anchors.dart
#	packages/jaspr/lib/src/server/adapters/client_component_adapter.dart
#	packages/jaspr/lib/src/server/server_binding.dart
#	packages/jaspr_builder/lib/src/client/client_module_builder.dart
#	packages/jaspr_builder/lib/src/codec/codecs.dart
#	packages/jaspr_builder/lib/src/sync/sync_mixins_builder.dart
#	packages/jaspr_builder/test/client/sources/bundle.dart
#	packages/jaspr_builder/test/client/sources/client_basic.dart
#	packages/jaspr_builder/test/client/sources/client_model_class.dart
#	packages/jaspr_builder/test/client/sources/client_model_extension.dart
#	packages/jaspr_builder/test/codec/sources/bundle.dart
#	packages/jaspr_builder/test/codec/sources/model_class.dart
#	packages/jaspr_builder/test/codec/sources/model_extension.dart
#	packages/jaspr_builder/test/sync/sources/sync_basic.dart
#	packages/jaspr_builder/test/sync/sources/sync_multi.dart
@docs-page
Copy link
Copy Markdown

docs-page bot commented Mar 16, 2026

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~776

Documentation is deployed and generated using docs.page.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Package Version Report

The following packages have been updated:
jaspr_test : 0.22.3 -> 0.23.0
jaspr : 0.22.3 -> 0.23.0
jaspr_builder : 0.22.3 -> 0.23.0
jaspr_cli : 0.22.3 -> 0.23.0
jaspr_content : 0.5.0 -> 0.5.1
jaspr_lints : 0.6.0 -> 0.6.1
jaspr_router : 0.8.1 -> 0.8.2
jaspr_flutter_embed : 0.4.10 -> 0.4.11
jaspr_riverpod : 0.4.4 -> 0.4.5
jaspr_serverpod : 0.6.0 -> 0.6.1

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 51.73410% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.25%. Comparing base (ea3a532) to head (2034181).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/jaspr/lib/src/client/component_anchors.dart 55.38% 29 Missing ⚠️
packages/jaspr/lib/src/client/client_binding.dart 35.29% 22 Missing ⚠️
packages/jaspr/lib/src/framework/build_owner.dart 0.00% 21 Missing ⚠️
.../src/server/adapters/client_component_adapter.dart 41.93% 18 Missing ⚠️
packages/jaspr/lib/src/server/server_handler.dart 19.04% 17 Missing ⚠️
packages/jaspr/lib/src/framework/framework.dart 22.22% 7 Missing ⚠️
packages/jaspr/lib/src/client/client_app.dart 50.00% 6 Missing ⚠️
...es/jaspr/lib/src/framework/stateful_component.dart 0.00% 6 Missing ⚠️
.../src/server/adapters/server_component_adapter.dart 0.00% 6 Missing ⚠️
...ackages/jaspr/lib/src/framework/render_object.dart 44.44% 5 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   60.82%   60.25%   -0.57%     
==========================================
  Files         196      198       +2     
  Lines       11188    11429     +241     
==========================================
+ Hits         6805     6887      +82     
- Misses       4383     4542     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!! I haven't tried it out yet, but some small questions and a few minor suggestions to consider:

Comment thread packages/jaspr/lib/src/client/component_anchors.dart Outdated
Comment thread packages/jaspr/lib/src/client/component_anchors.dart Outdated
Comment thread packages/jaspr/lib/src/client/options.dart Outdated
Comment thread packages/jaspr/lib/src/client/options.dart Outdated
Comment thread packages/jaspr/lib/src/client/options.dart Outdated
Comment on lines +72 to +73
for (var i = 0; i < _adapters.length; i++) {
final r = _adapters[i].prepare();

This comment was marked as resolved.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use foreach because new adapters can be added during .prepare(). I will add a comment.

Comment thread packages/jaspr/lib/src/server/server_binding.dart Outdated
Comment on lines +117 to +118
rootRenderObject.node = newNode;
rootRenderObject.toHydrate = [...newNode.childNodes.toIterable()];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe encapsulate this logic in a new method on RootDomRenderObject, so node doesn't need to have a public setter.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also I noticed I could remove some dead code in RootDomRenderObject.


/// Reloads the current page.
void reload([String? path]) {
throw UnimplementedError('Should be overridden on client and server.');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the client's AppContext extension doesn't have this method. Is that intended?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, that is leftover from I feature I was experimenting with but decided against for the initial version of server components. Will remove.

} else if (allowComponent &&
type.element.name == 'Component' &&
type.element.library.identifier == 'package:jaspr/src/framework/framework.dart') {
return (decoder: 'p.mount($argument)', cast: 'String');
Copy link
Copy Markdown
Contributor

@parlough parlough Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the component parameter is nullable? Should this consider the nullability suffix like the above handling?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@schultek schultek force-pushed the feat/server-components branch from 38c987f to e46ec38 Compare March 18, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants