Open
Conversation
Additional updates to the messaging for scarf.sh
aviaviavi
requested changes
Nov 29, 2024
|
|
||
| Regardless of the default state, Scarf will log what it is doing to users who | ||
| haven't explictly opted in or out. | ||
| Without having set either true or false, and instead SCARF_ANALYTICS is set to null, Scarf will log what those users are doing. |
Contributor
There was a problem hiding this comment.
This line should be reverted, not sure what we're trying to say with this line but this statement isn't true. The purpose of this sentence is to say scarf will log its own behavior to the end user.
Contributor
|
Most of this looks good! One change needed to merge. |
reverted change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional updates to the messaging for scarf.sh