Conversation
mzuehlke
left a comment
There was a problem hiding this comment.
Till now jgit was pinned to 5.x to so the plugin would still support JDK 8
see: https://github.com/sbt/sbt-dynver/blob/main/.scala-steward.conf
|
Wouldn't it make sense to bump the required JDK version for sbt plugins to 17 as well, now that Scala 3.8 and sbt 2 requires that as well? |
|
the plugin is crossbuilt for sbt 1 and sbt 2, and sbt 1 remains in wide use and as a rule, its plugin ecosystem is expected to work on JDK 8. (and sbt 2 is still in release candidates...) so I think what this PR needs to do is leave the dependency where it is on the sbt 1 side of the crossbuild, and take the upgrade only when building for sbt 2. this will be worth noting in the repo readme, I think (another possible path forward exists, namely to continue supporting JDK 8 only on a maintenance branch of the plugin, while on |
|
note also that this should be rebased now that #371 has been merged, since that one includes JDK 8 vs 17 stuff |
|
Currently I'm just overriding the |
Like an extra step in CI or extra CI job? Sure, that'd be fine. You could also document the situation in the repo readme. But also, I think we really do want to take the upgrade on the sbt 2 side. |
Direct motivation: support for worktrees