Draft
Conversation
It mostly continues to rely on tokens. But for a few things like endless method defs and multiline method continuations it uses AST. These are either very difficult or not possible to find just by checking tokens. Because of multiline method calls, comments now don't need to be trimmed anymore.
Say what the method does, versus saying why we're using it
This might never be a hotspot, but I had to optimize away some sorts in other locations. My preference is to sort once if the value won't be changing (this also assumes we won't re-use a visitor once used, perhaps we need to check and error if that assumption doesn't hold).
Every other file in the project already has this pragma. visitor.rb was the only one missing it. standardrb intentionally excludes the frozen_string_literal cop (standardrb/standard#181) so the linter wouldn't flag this.
`code_line.rb` was calling `visitor.consecutive_lines.include?` which is an O(n) array scan inside an O(n) loop over source lines — O(n²) total. `token.rb` was calling `visitor.endless_def_keyword_locs.include?` which is O(n) per token. Add `consecutive_line?(line)` backed by the existing hash for O(1) lookup, and `endless_def_loc?(location)` backed by a new hash keyed on `start_offset` for O(1) lookup. Freeze both hashes after `visit` to signal they are read-only after construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.