BugReference: Add new BugReference type; adds #92#102
Open
kallisti5 wants to merge 1 commit intorobinst:mainfrom
Open
BugReference: Add new BugReference type; adds #92#102kallisti5 wants to merge 1 commit intorobinst:mainfrom
kallisti5 wants to merge 1 commit intorobinst:mainfrom
Conversation
* Add a str as well as an href output, this allows printing the matching bug number, or the resulting url based on the configured prefix.
Author
|
Not 100% sure on the split apart href vs str design... it feels a bit anti-pattern to how things work now? 🤔 |
Author
|
ah yeah, the "link.href()" is probably taking it too far. linkify doesn't need to be aware of the prefix, just match bug numbers and let the consumer handle the prefix url stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug number, or the resulting url based on the configured prefix.