Update dependencies and enable build and configuration cache#15
Open
Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Open
Update dependencies and enable build and configuration cache#15Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Conversation
Contributor
Author
|
@fire-light42 just FYI (no hurries just not sure if this repo is monitored as much as just want to make aware of it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested running this on a repo still using AGP 8 as well as a new one using AGP 9 as well. Both still work.
This also adds
@CacheableTaskand@get:PathSensitiveannotations to tasks in order for incremental builds of this plugin (in particular thevalidatePluginstask which runs with build by default) to pass with configuration cache as well.AGP 9.2.0 includes non backwards compatible changes, which means for any extension to use it, they have to upgrade to AGP 9.2.0 and so do we in this repo. If either tries to update to it before the other, the next build will fail. So once a majority of extensions are at least on AGP 9, we can do it then. Will be an easier bump at that point.