Migrate token generation to new action#2370
Open
Luna712 wants to merge 6 commits intorecloudstream:masterfrom
Open
Migrate token generation to new action#2370Luna712 wants to merge 6 commits intorecloudstream:masterfrom
Luna712 wants to merge 6 commits intorecloudstream:masterfrom
Conversation
Note that `GH_APP_ID` needs moved from secrets to vars, see https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables#defining-configuration-variables-for-multiple-workflows
Open
2 tasks
Contributor
Author
|
@fire-light42 this is tested on my fork now. But does require some changes to secrets as explained in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GitHub settings, the secret
GH_APP_IDshould be deleted, replaced with a var (https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables#defining-configuration-variables-for-multiple-workflows) calledAPP_CLIENT_IDwhich should be the client ID for the GitHub App rather than the current App ID usage. Additionally, the secretGH_APP_KEYshould be renamed toAPP_PRIVATE_KEY. I was just following the exact examples on https://github.com/actions/create-github-app-token.I have tested all actions except the issue actions, though I could easily test it also but it shouldn't have any issues. As a result of my testing in my fork, I also made the actions more usable in forks as long as you have the necessary repositories and signing keys. That should also make testing action changes (such as the rest of #2367) easier for me personally and potentially others in the future as well.
Does part of #2367. I plan to do the rest of that (replace the release action) after this one is done. Making it more generic and usable in forks will make that easier as well.