Add widgetDependencies() S3 generic#255
Open
cpsievert wants to merge 2 commits into
Open
Conversation
Owner
|
This looks good @cpsievert. Let me test through a couple of scenarios before I merge it in. |
widgetDependencies() is a public S3 generic with character and htmlwidget methods. The htmlwidget method returns all dependencies (YAML + binding + runtime), fixing under-reporting when deps are added via createWidget(). Internally, toHTML() and shinyRenderWidget() now use widgetDependencies(x) as the single canonical path for resolving widget dependencies.
cpsievert
force-pushed
the
carson/feature/getDependency
branch
from
d83dd5b to
f247f62
Compare
cpsievert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widgetDependencies()as a public S3 generic withcharacterandhtmlwidgetmethodshtmlwidgetmethod returns all dependencies (YAML-declared + JS binding + runtimedependenciesslot), fixing under-reporting when deps are added dynamically viacreateWidget(dependencies = ...)toHTML()andshinyRenderWidget()now usewidgetDependencies(x)as the single canonical path for resolving widget dependenciesgetDependency()is preserved as a deprecated internal aliasMotivation
Previously there was no public API to get the complete set of HTML dependencies from a widget object.
getDependency(name, package)only returned the YAML + binding deps, missing any runtime dependencies added under thedependenciesslot. This made it difficult for downstream code to introspect widget dependencies accurately.Breaking changes
getDependency()now emits a deprecation warning directing users towidgetDependencies()x(positional callers are unaffected)