Skip to content

SIR-1523 - Validate watched saves before upload#69

Open
KeinerM wants to merge 2 commits intosir-1522-cli-v2-pre-flight-validation-gate-on-raisely-deploy-no-validatefrom
sir-1523-cli-v2-per-save-validation-in-raisely-start
Open

SIR-1523 - Validate watched saves before upload#69
KeinerM wants to merge 2 commits intosir-1522-cli-v2-pre-flight-validation-gate-on-raisely-deploy-no-validatefrom
sir-1523-cli-v2-per-save-validation-in-raisely-start

Conversation

@KeinerM
Copy link
Copy Markdown

@KeinerM KeinerM commented May 6, 2026

What changed

  • Added per-save validation to raisely start for campaign styles and components before upload.
  • On validation failure, the watcher now prints the validator error inline and skips upload for that save.
  • Refactored watcher setup into a testable registration function so watcher behavior can be verified directly.
  • Added tests covering invalid SCSS saves, invalid component saves, watcher persistence after failure, and successful recovery on the next valid save.

Note

Medium Risk
Adds new preflight/per-save validation that can block deploy/start uploads and changes test runner/dependencies, which may affect developer workflows and release behavior if validators misreport or become unavailable.

Overview
Adds SCSS/component validation gates before uploading changes.

raisely start now validates campaign stylesheet saves and component saves via validateCampaignSass/validateComponent; failed validation prints the validator error and skips that upload while keeping watchers running (watcher logic extracted into testable helpers).

raisely deploy gains a default preflight validation step across configured campaigns and local components (with concurrency limiting) and a --no-validate escape hatch; deploy flow is refactored for dependency injection and improved error handling (e.g., missing components/ no longer crashes).

Switches tests from node:test to vitest, adds vitest to devDependencies, and introduces a package-lock.json.

Reviewed by Cursor Bugbot for commit 6f305bb. Bugbot is set up for automated code reviews on this repo. Configure here.

@KeinerM KeinerM requested a review from xolott-ark May 6, 2026 17:15
@KeinerM KeinerM self-assigned this May 6, 2026
KeinerM and others added 2 commits May 7, 2026 10:36
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@KeinerM KeinerM force-pushed the sir-1523-cli-v2-per-save-validation-in-raisely-start branch from 6c4f31a to 6f305bb Compare May 7, 2026 14:54
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6f305bb. Configure here.

Comment thread src/start.js
Comment thread src/deploy.js
Comment thread src/deploy.js
@KeinerM KeinerM changed the base branch from develop to sir-1522-cli-v2-pre-flight-validation-gate-on-raisely-deploy-no-validate May 7, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant