SIR-1523 - Validate watched saves before upload#69
Open
KeinerM wants to merge 2 commits intosir-1522-cli-v2-pre-flight-validation-gate-on-raisely-deploy-no-validatefrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
6c4f31a to
6f305bb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f305bb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
raisely startfor campaign styles and components before upload.Note
Medium Risk
Adds new preflight/per-save validation that can block
deploy/startuploads and changes test runner/dependencies, which may affect developer workflows and release behavior if validators misreport or become unavailable.Overview
Adds SCSS/component validation gates before uploading changes.
raisely startnow validates campaign stylesheet saves and component saves viavalidateCampaignSass/validateComponent; failed validation prints the validator error and skips that upload while keeping watchers running (watcher logic extracted into testable helpers).raisely deploygains a default preflight validation step across configured campaigns and local components (with concurrency limiting) and a--no-validateescape hatch; deploy flow is refactored for dependency injection and improved error handling (e.g., missingcomponents/no longer crashes).Switches tests from
node:testtovitest, addsvitestto devDependencies, and introduces apackage-lock.json.Reviewed by Cursor Bugbot for commit 6f305bb. Bugbot is set up for automated code reviews on this repo. Configure here.