Closed
Conversation
Contributor
Contributor
Author
|
my fix is much better than what you did IMO, can you integrate it into your PR? |
Contributor
What do you think? |
Owner
|
Unless there is another reason, this PRs change is preferable. |
onemen
added a commit
to onemen/npm-check-updates
that referenced
this pull request
Apr 11, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"lsof" does not exist on Windows, so this uses a Bash native solution - the special
$!variable.The CI tests passing should be proof that this is fine.