Open
Conversation
2 tasks
Contributor
|
Have you compared it with io.Copy? It seems that io.Copy is more compatible and not fallback to io.ReadAll(). In my work environment there is only Fd() uintptr (not found Fd() int), and I am not sure why, so I am unable to conduct effective testing mmap. |
Contributor
Author
|
My bad, you're right, Fd() returns uintptr. This mmap is not for speed, it's for decreasing RSS by using the kernel-supplied probably-in-filecache []byte of the file. |
os.File.Fd() never returned int...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Use mmap instead of io.ReadAll, if possible
Description
Introduce readAll function which uses mmap if possible, io.ReadAll otherwise.
Related Issue
#2121
Motivation and Context
Memory inefficiency.
How Has This Been Tested
go test
Types of changes
Checklist