Open
Conversation
yguclu
requested changes
Sep 5, 2024
Author
|
I've deleted all the .DS_Store files and modified the .gitignore suscessfully. |
yguclu
requested changes
Sep 17, 2024
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
campospinto
reviewed
Oct 9, 2024
| _expressions = {'x': 'a * (x1 + eps / (2*pi) * sin(2*pi*x1) * sin(2*pi*x2))', | ||
| 'y': 'b * (x2 + eps / (2*pi) * sin(2*pi*x1) * sin(2*pi*x2))'} | ||
|
|
||
| mapping = CollelaMapping2D('M', a=1, b=1, eps=.2) |
Collaborator
There was a problem hiding this comment.
the CollelaMapping2D from sympde has k1 and k2 as parameters. This line is probably wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to link with Sympde PR#168, where the new hierarchy is showed.
The interface is now simpler. An example can be in the files changed of this PR, in psydac/api/postprocessing.py, in the _get_mesh function l. 2286 :
There is no callable mapping anymore. So the type of the mapping now is either : spline, analytic or None. ANd you may do directly evaluations on the object without getting a callable argument or so.
This new hierarchy maintains "domain undefined mapping", that you may get from the Domain.from_file method.
Now, in the tests, the real mappings (the "defined" or "callable" version), can be obtained from domain_h.mappings (returns a list of mappings, either spline or analytic) : see psydac.api.tests.test_api_feec_2d.py
An improvement could be done in this mapping encapsulation. Which class should have the "defined" mapping, to have the most user-friendly tests. For example in psydac.api.tests.test_api_feec_2d.py, you must set the mapping attribute, of the derham object :