Skip to content

chore: remove primer_react_spinner_synchronize_animations feature flag #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddharthkp merged 4 commits into from
Apr 13, 2026
Merged

chore: remove primer_react_spinner_synchronize_animations feature flag #7739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7104b25
chore: remove primer_react_spinner_synchronize_animations feature flag
Copilot Apr 9, 2026
45183f5
add changeset
siddharthkp Apr 9, 2026
4ee4f42
test: update TextInputWithTokens snapshot for spinner animation sync
Copilot Apr 9, 2026
87fba3a
Merge branch 'main' into copilot/remove-primer-react-spinner-flag
siddharthkp Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/skills/feature-flags/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ function MyOverlay() {

## Real Codebase Examples

### Spinner animation sync (`packages/react/src/Spinner/Spinner.tsx`)

```tsx
const syncAnimationsEnabled = useFeatureFlag('primer_react_spinner_synchronize_animations')
const shouldSync = syncAnimationsEnabled && noMotionPreference
const mergedStyle = shouldSync ? {...style, animationDelay: `${syncDelay}ms`} : style
```

### CSS anchor positioning (`packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx`)

```tsx
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/FeatureFlags/DefaultFeatureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ export const DefaultFeatureFlags = FeatureFlagScope.create({
primer_react_select_panel_fullscreen_on_narrow: false,
primer_react_select_panel_order_selected_at_top: false,
primer_react_select_panel_remove_active_descendant: false,
primer_react_spinner_synchronize_animations: false,
primer_react_overlay_max_height_clamp_to_viewport: false,
})
5 changes: 1 addition & 4 deletions packages/react/src/Spinner/Spinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {HTMLDataAttributes} from '../internal/internal-types'
import {useId} from '../hooks'
import classes from './Spinner.module.css'
import {useMedia} from '../hooks/useMedia'
import {useFeatureFlag} from '../FeatureFlags'

const ANIMATION_DURATION_MS = 1000

Expand Down Expand Up @@ -38,7 +37,6 @@ function Spinner({
delay = false,
...props
}: SpinnerProps) {
const syncAnimationsEnabled = useFeatureFlag('primer_react_spinner_synchronize_animations')
const noMotionPreference = useMedia('(prefers-reduced-motion: no-preference)', false)
const size = sizeMap[sizeKey]
const hasHiddenLabel = srText !== null && ariaLabel === undefined
Expand All @@ -64,8 +62,7 @@ function Spinner({
return null
}

const shouldSync = syncAnimationsEnabled && noMotionPreference
const mergedStyle = shouldSync ? {...style, animationDelay: `${syncDelay}ms`} : style
const mergedStyle = noMotionPreference ? {...style, animationDelay: `${syncDelay}ms`} : style
Comment thread
siddharthkp marked this conversation as resolved.

return (
/* inline-flex removes the extra line height */
Expand Down
Loading