use zend_string_equals* APIs for string comparisons#21707
Open
LamentXU123 wants to merge 4 commits intophp:masterfrom
Open
use zend_string_equals* APIs for string comparisons#21707LamentXU123 wants to merge 4 commits intophp:masterfrom
zend_string_equals* APIs for string comparisons#21707LamentXU123 wants to merge 4 commits intophp:masterfrom
Conversation
devnexen
reviewed
Apr 10, 2026
devnexen
reviewed
Apr 10, 2026
Member
|
your changes look correct ! but will let the code-owners decide about it. |
iluuu1994
reviewed
Apr 13, 2026
| /* we we're looking for a private prop but found a non private one of the same name */ | ||
| return FAILURE; | ||
| } else if (strcmp(ZSTR_VAL(prop_info_name)+1, ZSTR_VAL(property_info->name)+1)) { | ||
| } else if (!zend_string_equals(prop_info_name, property_info->name)) { |
Member
There was a problem hiding this comment.
Technically this changes behavior, i.e. it compares the entire string rather than just the class name. For context, private property names have the mangled format "\0class_name\0property_name". I'd probably revert this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the zend_string APIs
zend_string_equals*which are clearer, and can also do some pointer comparisons if the strings are interned for any reason.