Remove outdated comment

kamil-tekiela · kamil-tekiela · commit 9b3640f470fb · 2026-04-11T14:26:19.000+01:00
diff --git a/ext/mysqlnd/mysqlnd_result.c b/ext/mysqlnd/mysqlnd_result.c
@@ -1001,13 +1001,6 @@ MYSQLND_METHOD(mysqlnd_res, fetch_into)(MYSQLND_RES * result, const unsigned int
 			}
 		}
 		if (flags & MYSQLND_FETCH_ASSOC) {
-			/* zend_hash_quick_update needs length + trailing zero */
-			/* QQ: Error handling ? */
-			/*
-			  zend_hash_quick_update does not check, as add_assoc_zval_ex do, whether
-			  the index is a numeric and convert it to it. This however means constant
-			  hashing of the column name, which is not needed as it can be precomputed.
-			*/
 			Z_TRY_ADDREF_P(data);
 			if (field->is_numeric == FALSE) {
 				zend_hash_update(row_ht, field->sname, data);

Original file line number	Diff line number	Diff line change
`@@ -1001,13 +1001,6 @@ MYSQLND_METHOD(mysqlnd_res, fetch_into)(MYSQLND_RES * result, const unsigned int`
`1001`	`1001`	`}`
`1002`	`1002`	`}`
`1003`	`1003`	`if (flags & MYSQLND_FETCH_ASSOC) {`
`1004`		`- /* zend_hash_quick_update needs length + trailing zero */`
`1005`		`- /* QQ: Error handling ? */`
`1006`		`- /*`
`1007`		`- zend_hash_quick_update does not check, as add_assoc_zval_ex do, whether`
`1008`		`- the index is a numeric and convert it to it. This however means constant`
`1009`		`- hashing of the column name, which is not needed as it can be precomputed.`
`1010`		`- */`
`1011`	`1004`	`Z_TRY_ADDREF_P(data);`
`1012`	`1005`	`if (field->is_numeric == FALSE) {`
`1013`	`1006`	`zend_hash_update(row_ht, field->sname, data);`