Skip to content

Commit eec86c5

Browse files
committed
Use iterated struct and remove dulicate SET_AFFECTED_ROWS
1 parent e60f880 commit eec86c5

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

ext/mysqlnd/mysqlnd_result.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -722,9 +722,6 @@ MYSQLND_METHOD(mysqlnd_res, store_result_fetch_data)(MYSQLND_CONN_DATA * const c
722722

723723
if (ret == FAIL) {
724724
COPY_CLIENT_ERROR(&set->error_info, row_packet.error_info);
725-
} else {
726-
/* libmysql's documentation says it should be so for SELECT statements */
727-
UPSERT_STATUS_SET_AFFECTED_ROWS(conn->upsert_status, set->row_count);
728725
}
729726
DBG_INF_FMT("ret=%s row_count=%u warnings=%u server_status=%u",
730727
ret == PASS? "PASS":"FAIL",
@@ -1012,10 +1009,10 @@ MYSQLND_METHOD(mysqlnd_res, fetch_into)(MYSQLND_RES * result, const unsigned int
10121009
hashing of the column name, which is not needed as it can be precomputed.
10131010
*/
10141011
Z_TRY_ADDREF_P(data);
1015-
if (meta->fields[i].is_numeric == FALSE) {
1016-
zend_hash_update(row_ht, meta->fields[i].sname, data);
1012+
if (field->is_numeric == FALSE) {
1013+
zend_hash_update(row_ht, field->sname, data);
10171014
} else {
1018-
zend_hash_index_update(row_ht, meta->fields[i].num_key, data);
1015+
zend_hash_index_update(row_ht, field->num_key, data);
10191016
}
10201017
}
10211018

0 commit comments

Comments
 (0)