Fix PHPStan errors

devnix · devnix · commit fe5c2ed80cbb · 2025-05-03T16:19:18.000+02:00
diff --git a/src/Scanner/CodeScanner.php b/src/Scanner/CodeScanner.php
@@ -110,7 +110,7 @@ protected function addComments(ParsedFunction $function, ?Translation $translati
 
     protected function addFlags(ParsedFunction $function, ?Translation $translation): ?Translation
     {
-        if (!$translation instanceof \Gettext\Translation) {
+        if ($translation === null) {
             return $translation;
         }
 
diff --git a/tests/BasePoLoaderTestCase.php b/tests/BasePoLoaderTestCase.php
@@ -257,8 +257,6 @@ public function stringDecodeProvider()
 
     /**
      * @dataProvider stringDecodeProvider
-     * @param mixed $source
-     * @param mixed $decoded
      */
     public function testStringDecode(string $source, string $decoded): void
     {
diff --git a/tests/PoGeneratorTest.php b/tests/PoGeneratorTest.php
@@ -109,8 +109,6 @@ public function stringEncodeProvider(): array
 
     /**
      * @dataProvider stringEncodeProvider
-     * @param mixed $encoded
-     * @param mixed $decoded
      */
     public function testStringEncode(string $encoded, string $decoded): void
     {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ protected function addComments(ParsedFunction $function, ?Translation $translati`
`110`	`110`
`111`	`111`	`protected function addFlags(ParsedFunction $function, ?Translation $translation): ?Translation`
`112`	`112`	`{`
`113`		`- if (!$translation instanceof \Gettext\Translation) {`
	`113`	`+ if ($translation === null) {`
`114`	`114`	`return $translation;`
`115`	`115`	`}`
`116`	`116`
Original file line number	Diff line number	Diff line change
`@@ -257,8 +257,6 @@ public function stringDecodeProvider()`
`257`	`257`
`258`	`258`	`/**`
`259`	`259`	`* @dataProvider stringDecodeProvider`
`260`		`- * @param mixed $source`
`261`		`- * @param mixed $decoded`
`262`	`260`	`*/`
`263`	`261`	`public function testStringDecode(string $source, string $decoded): void`
`264`	`262`	`{`
Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,6 @@ public function stringEncodeProvider(): array`
`109`	`109`
`110`	`110`	`/**`
`111`	`111`	`* @dataProvider stringEncodeProvider`
`112`		`- * @param mixed $encoded`
`113`		`- * @param mixed $decoded`
`114`	`112`	`*/`
`115`	`113`	`public function testStringEncode(string $encoded, string $decoded): void`
`116`	`114`	`{`