Skip to content

Commit 7d582c7

Browse files
devnixdevnix
committed
Add type coverage
1 parent 781f01e commit 7d582c7

6 files changed

Lines changed: 32 additions & 32 deletions

File tree

‎rector.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
__DIR__ . '/tests',
1212
])
1313
->withPhpSets()
14-
->withTypeCoverageLevel(2)
14+
->withPreparedSets(typeDeclarations: true)
1515
->withDeadCodeLevel(2)
1616
->withCodeQualityLevel(10)
1717
->withCodingStyleLevel(0)

‎src/Scanner/CodeScanner.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ protected function getFunctionHandler(ParsedFunction $function): ?callable
9595

9696
protected function addComments(ParsedFunction $function, ?Translation $translation): ?Translation
9797
{
98-
if (empty($this->commentsPrefixes) || empty($translation)) {
98+
if (empty($this->commentsPrefixes) || !$translation instanceof \Gettext\Translation) {
9999
return $translation;
100100
}
101101

@@ -110,7 +110,7 @@ protected function addComments(ParsedFunction $function, ?Translation $translati
110110

111111
protected function addFlags(ParsedFunction $function, ?Translation $translation): ?Translation
112112
{
113-
if (empty($translation)) {
113+
if (!$translation instanceof \Gettext\Translation) {
114114
return $translation;
115115
}
116116

‎tests/BasePoLoaderTestCase.php‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testPoLoader(): void
7373
$this->assertSame('bs', $translations->getLanguage());
7474
}
7575

76-
private function translation1(Translation $translation)
76+
private function translation1(Translation $translation): void
7777
{
7878
$this->assertSame(
7979
'Ensure this value has at least %(limit_value)d character (it has %sd).',
@@ -87,7 +87,7 @@ private function translation1(Translation $translation)
8787
$this->assertSame(['', ''], $translation->getPluralTranslations());
8888
}
8989

90-
private function translation2(Translation $translation)
90+
private function translation2(Translation $translation): void
9191
{
9292
$this->assertSame(
9393
'Ensure this value has at most %(limit_value)d character (it has %sd).',
@@ -101,15 +101,15 @@ private function translation2(Translation $translation)
101101
$this->assertSame(['', ''], $translation->getPluralTranslations());
102102
}
103103

104-
private function translation3(Translation $translation)
104+
private function translation3(Translation $translation): void
105105
{
106106
$this->assertSame('%ss must be unique for %ss %ss.', $translation->getOriginal());
107107
$this->assertNull($translation->getPlural());
108108
$this->assertSame('%ss mora da bude jedinstven za %ss %ss.', $translation->getTranslation());
109109
$this->assertCount(0, $translation->getPluralTranslations());
110110
}
111111

112-
private function translation4(Translation $translation)
112+
private function translation4(Translation $translation): void
113113
{
114114
$this->assertSame('and', $translation->getOriginal());
115115
$this->assertNull($translation->getPlural());
@@ -118,7 +118,7 @@ private function translation4(Translation $translation)
118118
$this->assertSame(['c-format'], $translation->getFlags()->toArray());
119119
}
120120

121-
private function translation5(Translation $translation)
121+
private function translation5(Translation $translation): void
122122
{
123123
$this->assertSame('Value %sr is not a valid choice.', $translation->getOriginal());
124124
$this->assertNull($translation->getPlural());
@@ -127,7 +127,7 @@ private function translation5(Translation $translation)
127127
$this->assertSame(['This is a extracted comment'], $translation->getExtractedComments()->toArray());
128128
}
129129

130-
private function translation6(Translation $translation)
130+
private function translation6(Translation $translation): void
131131
{
132132
$this->assertSame('This field cannot be null.', $translation->getOriginal());
133133
$this->assertNull($translation->getPlural());
@@ -137,7 +137,7 @@ private function translation6(Translation $translation)
137137
$this->assertSame(['C:/Users/Me/Documents/foo2.php' => [1]], $translation->getReferences()->toArray());
138138
}
139139

140-
private function translation7(Translation $translation)
140+
private function translation7(Translation $translation): void
141141
{
142142
$this->assertSame('This field cannot be blank.', $translation->getOriginal());
143143
$this->assertNull($translation->getPlural());
@@ -147,7 +147,7 @@ private function translation7(Translation $translation)
147147
$this->assertSame(['C:/Users/Me/Documents/foo1.php' => []], $translation->getReferences()->toArray());
148148
}
149149

150-
private function translation8(Translation $translation)
150+
private function translation8(Translation $translation): void
151151
{
152152
$this->assertSame('Field of type: %ss', $translation->getOriginal());
153153
$this->assertNull($translation->getPlural());
@@ -163,7 +163,7 @@ private function translation8(Translation $translation)
163163
);
164164
}
165165

166-
private function translation9(Translation $translation)
166+
private function translation9(Translation $translation): void
167167
{
168168
$this->assertSame('Integer', $translation->getOriginal());
169169
$this->assertNull($translation->getPlural());
@@ -174,7 +174,7 @@ private function translation9(Translation $translation)
174174
$this->assertSame(['a simple line comment is above'], $translation->getComments()->toArray());
175175
}
176176

177-
private function translation10(Translation $translation)
177+
private function translation10(Translation $translation): void
178178
{
179179
$this->assertSame('{test1}', $translation->getOriginal());
180180
$this->assertNull($translation->getPlural());
@@ -191,7 +191,7 @@ private function translation10(Translation $translation)
191191
);
192192
}
193193

194-
private function translation11(Translation $translation)
194+
private function translation11(Translation $translation): void
195195
{
196196
$this->assertSame('{test2}', $translation->getOriginal());
197197
$this->assertNull($translation->getPlural());
@@ -205,7 +205,7 @@ private function translation11(Translation $translation)
205205
);
206206
}
207207

208-
private function translation12(Translation $translation)
208+
private function translation12(Translation $translation): void
209209
{
210210
$this->assertSame('Multibyte test', $translation->getOriginal());
211211
$this->assertNull($translation->getPlural());
@@ -215,7 +215,7 @@ private function translation12(Translation $translation)
215215
$this->assertCount(0, $translation->getReferences());
216216
}
217217

218-
private function translation13(Translation $translation)
218+
private function translation13(Translation $translation): void
219219
{
220220
$this->assertSame('Tabulation test', $translation->getOriginal());
221221
$this->assertNull($translation->getPlural());
@@ -225,7 +225,7 @@ private function translation13(Translation $translation)
225225
$this->assertCount(0, $translation->getReferences());
226226
}
227227

228-
private function translation14(Translation $translation)
228+
private function translation14(Translation $translation): void
229229
{
230230
$this->assertSame('%s has been added to your cart.', $translation->getOriginal());
231231
$this->assertSame('%s have been added to your cart.', $translation->getPlural());
@@ -260,7 +260,7 @@ public function stringDecodeProvider()
260260
* @param mixed $source
261261
* @param mixed $decoded
262262
*/
263-
public function testStringDecode($source, $decoded): void
263+
public function testStringDecode(string $source, string $decoded): void
264264
{
265265
$po = <<<EOT
266266
msgid "source"

‎tests/MergeTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function testScanAndLoadStrategy(): void
126126
$this->assertSnapshot(__FUNCTION__, $merged);
127127
}
128128

129-
private function assertSnapshot(string $name, Translations $translations, bool $forceCreate = false)
129+
private function assertSnapshot(string $name, Translations $translations, bool $forceCreate = false): void
130130
{
131131
$file = __DIR__."/snapshots/{$name}.php";
132132
$array = $translations->toArray();

‎tests/MoLoaderTest.php‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,87 +54,87 @@ public function testMoLoader(): void
5454
$this->assertSame('bs', $translations->getLanguage());
5555
}
5656

57-
private function translation0(Translation $translation)
57+
private function translation0(Translation $translation): void
5858
{
5959
$this->assertSame('%s has been added to your cart.', $translation->getOriginal());
6060
$this->assertSame('%s have been added to your cart.', $translation->getPlural());
6161
$this->assertSame('%s has been added to your cart.', $translation->getTranslation());
6262
$this->assertCount(1, $translation->getPluralTranslations());
6363
}
6464

65-
private function translation1(Translation $translation)
65+
private function translation1(Translation $translation): void
6666
{
6767
$this->assertSame('%ss must be unique for %ss %ss.', $translation->getOriginal());
6868
$this->assertNull($translation->getPlural());
6969
$this->assertSame('%ss mora da bude jedinstven za %ss %ss.', $translation->getTranslation());
7070
$this->assertCount(0, $translation->getPluralTranslations());
7171
}
7272

73-
private function translation2(Translation $translation)
73+
private function translation2(Translation $translation): void
7474
{
7575
$this->assertSame('Field of type: %ss', $translation->getOriginal());
7676
$this->assertNull($translation->getPlural());
7777
$this->assertSame('Polje tipa: %ss', $translation->getTranslation());
7878
$this->assertCount(0, $translation->getPluralTranslations());
7979
}
8080

81-
private function translation3(Translation $translation)
81+
private function translation3(Translation $translation): void
8282
{
8383
$this->assertSame('Integer', $translation->getOriginal());
8484
$this->assertNull($translation->getPlural());
8585
$this->assertSame('Cijeo broj', $translation->getTranslation());
8686
$this->assertCount(0, $translation->getPluralTranslations());
8787
}
8888

89-
private function translation4(Translation $translation)
89+
private function translation4(Translation $translation): void
9090
{
9191
$this->assertSame('Multibyte test', $translation->getOriginal());
9292
$this->assertNull($translation->getPlural());
9393
$this->assertSame('日本人は日本で話される言語です！', $translation->getTranslation());
9494
$this->assertCount(0, $translation->getPluralTranslations());
9595
}
9696

97-
private function translation5(Translation $translation)
97+
private function translation5(Translation $translation): void
9898
{
9999
$this->assertSame('Tabulation test', $translation->getOriginal());
100100
$this->assertNull($translation->getPlural());
101101
$this->assertSame("FIELD\tFIELD", $translation->getTranslation());
102102
$this->assertCount(0, $translation->getPluralTranslations());
103103
}
104104

105-
private function translation6(Translation $translation)
105+
private function translation6(Translation $translation): void
106106
{
107107
$this->assertSame('This field cannot be blank.', $translation->getOriginal());
108108
$this->assertNull($translation->getPlural());
109109
$this->assertSame('Ovo polje ne može biti prazno.', $translation->getTranslation());
110110
$this->assertCount(0, $translation->getPluralTranslations());
111111
}
112112

113-
private function translation7(Translation $translation)
113+
private function translation7(Translation $translation): void
114114
{
115115
$this->assertSame('This field cannot be null.', $translation->getOriginal());
116116
$this->assertNull($translation->getPlural());
117117
$this->assertSame('Ovo polje ne može ostati prazno.', $translation->getTranslation());
118118
$this->assertCount(0, $translation->getPluralTranslations());
119119
}
120120

121-
private function translation8(Translation $translation)
121+
private function translation8(Translation $translation): void
122122
{
123123
$this->assertSame('and', $translation->getOriginal());
124124
$this->assertNull($translation->getPlural());
125125
$this->assertSame('i', $translation->getTranslation());
126126
$this->assertCount(0, $translation->getPluralTranslations());
127127
}
128128

129-
private function translation9(Translation $translation)
129+
private function translation9(Translation $translation): void
130130
{
131131
$this->assertSame('{test1}', $translation->getOriginal());
132132
$this->assertNull($translation->getPlural());
133133
$this->assertSame("test1\n<div>\n test2\n</div>\ntest3", $translation->getTranslation());
134134
$this->assertCount(0, $translation->getPluralTranslations());
135135
}
136136

137-
private function translation10(Translation $translation)
137+
private function translation10(Translation $translation): void
138138
{
139139
$this->assertSame('{test2}', $translation->getOriginal());
140140
$this->assertNull($translation->getPlural());

‎tests/PoGeneratorTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public function testPoLoader(): void
9696
$this->assertSame($expected, $result);
9797
}
9898

99-
public function stringEncodeProvider()
99+
public function stringEncodeProvider(): array
100100
{
101101
return [
102102
['"test"', 'test'],
@@ -112,7 +112,7 @@ public function stringEncodeProvider()
112112
* @param mixed $encoded
113113
* @param mixed $decoded
114114
*/
115-
public function testStringEncode($encoded, $decoded): void
115+
public function testStringEncode(string $encoded, string $decoded): void
116116
{
117117
$this->assertSame($encoded, PoGenerator::encode($decoded));
118118
}

0 commit comments

Comments
 (0)