REF: Remove TimedeltaArray._from_sequence_not_strict#65162
Merged
mroeschke merged 1 commit intopandas-dev:mainfrom Apr 11, 2026
Merged
REF: Remove TimedeltaArray._from_sequence_not_strict#65162mroeschke merged 1 commit intopandas-dev:mainfrom
mroeschke merged 1 commit intopandas-dev:mainfrom
Conversation
Move freq pinning to TimedeltaIndex.__new__ so the array constructor uses only the standard _from_sequence signature. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mroeschke
approved these changes
Apr 11, 2026
Member
|
Thanks @jbrockmendel |
Sharl0tteIsTaken
added a commit
to Sharl0tteIsTaken/pandas
that referenced
this pull request
Apr 12, 2026
…-comparison * upstream/main: CI: Add repo flag to GHA cache cleaup workflow (pandas-dev#65167) DOC: clarify unit parameter in to_datetime docstring (pandas-dev#65155) BUG: raise clear TypeError for ExtensionArray.fillna with dict value (pandas-dev#65157) REF: consolidate __iter__ into TimelikeOps, standardize _validate_setitem_value (pandas-dev#65158) REF: Remove TimedeltaArray._from_sequence_not_strict (pandas-dev#65162) TST: mark test_dt64arr_cmp_arraylike_invalid[tzlocal] xfail on Windows (pandas-dev#64294) DOC: Add User Guide link to qcut docstring (pandas-dev#62357) (pandas-dev#63856) DOC: Update documentation for apply function behavior (pandas-dev#64236)
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 14, 2026
…ith_freq logic to Index - Remove freq parameter from DTA._from_sequence_not_strict; it no longer reads data.freq or calls _maybe_pin_freq - DTI.__new__ now extracts freq from incoming data and calls _maybe_pin_freq externally, following the pattern established for TDI in pandas-dev#65162 - Move _with_freq freq-resolution logic to DatetimeTimedeltaMixin._with_freq so the Index resolves "infer" before delegating to the array - Relax array _with_freq to accept BaseOffset on non-empty arrays (needed since the Index now resolves "infer" to an offset before passing down) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 15, 2026
…ith_freq logic to Index - Remove freq parameter from DTA._from_sequence_not_strict; it no longer reads data.freq or calls _maybe_pin_freq - DTI.__new__ now extracts freq from incoming data and calls _maybe_pin_freq externally, following the pattern established for TDI in pandas-dev#65162 - Move _with_freq freq-resolution logic to DatetimeTimedeltaMixin._with_freq so the Index resolves "infer" before delegating to the array - Relax array _with_freq to accept BaseOffset on non-empty arrays (needed since the Index now resolves "infer" to an offset before passing down) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimedeltaArray._from_sequence_not_strict, which was_from_sequenceplus freq pinning_maybe_pin_freqcall toTimedeltaIndex.__new__, keeping_from_sequencewith the standard EA signatureTest plan
pandas/tests/indexes/timedeltas/passpandas/tests/arrays/timedeltas/passpandas/tests/arrays/test_timedeltas.pypassespandas/tests/arrays/test_datetimelike.pypasses🤖 Generated with Claude Code