fix the condition for rendering old backlog list#22755
Merged
toy merged 1 commit intorelease/17.3from Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Backlogs controller rendering so Turbo Frame requests only return the legacy backlog list partial when the request targets the backlogs_container frame, preventing mismatched frame responses (and subsequent full-page reload fallbacks) in other Turbo interactions.
Changes:
- Replace broad
turbo_frame_request?check with aturbo_frame_request_idmatch forbacklogs_containerin the legacyindexaction. - Ensure non-
backlogs_containerTurbo Frame requests receive the full:indexrender path.
Comments suppressed due to low confidence (1)
modules/backlogs/app/controllers/rb_master_backlogs_controller.rb:60
- The updated branching introduces new behavior for Turbo Frame requests whose frame id is not "backlogs_container" (they now render the full :index view instead of the list partial). There is request spec coverage for the "backlogs_container" frame, but no coverage for a different Turbo-Frame header (e.g., "content-bodyRight"), which is the regression scenario this change is meant to address. Please add a request spec asserting that a non-backlogs_container turbo-frame request renders :index (and does not render the _list partial).
case turbo_frame_request_id
when "backlogs_container"
render partial: "list", layout: false
else
render :index
end
myabc
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/73448
What are you trying to accomplish?
See eac7243 #22721
Merge checklist