Skip to content

fix the condition for rendering old backlog list#22755

Merged
toy merged 1 commit intorelease/17.3from
opf/bug/73448-closing-the-work-package-split-view-reloads-whole-page-2
Apr 14, 2026
Merged

fix the condition for rendering old backlog list#22755
toy merged 1 commit intorelease/17.3from
opf/bug/73448-closing-the-work-package-split-view-reloads-whole-page-2

Conversation

@toy
Copy link
Copy Markdown
Contributor

@toy toy commented Apr 14, 2026

Ticket

https://community.openproject.org/wp/73448

What are you trying to accomplish?

See eac7243 #22721

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Backlogs controller rendering so Turbo Frame requests only return the legacy backlog list partial when the request targets the backlogs_container frame, preventing mismatched frame responses (and subsequent full-page reload fallbacks) in other Turbo interactions.

Changes:

  • Replace broad turbo_frame_request? check with a turbo_frame_request_id match for backlogs_container in the legacy index action.
  • Ensure non-backlogs_container Turbo Frame requests receive the full :index render path.
Comments suppressed due to low confidence (1)

modules/backlogs/app/controllers/rb_master_backlogs_controller.rb:60

  • The updated branching introduces new behavior for Turbo Frame requests whose frame id is not "backlogs_container" (they now render the full :index view instead of the list partial). There is request spec coverage for the "backlogs_container" frame, but no coverage for a different Turbo-Frame header (e.g., "content-bodyRight"), which is the regression scenario this change is meant to address. Please add a request spec asserting that a non-backlogs_container turbo-frame request renders :index (and does not render the _list partial).
    case turbo_frame_request_id
    when "backlogs_container"
      render partial: "list", layout: false
    else
      render :index
    end

@toy toy merged commit 4f00440 into release/17.3 Apr 14, 2026
20 of 22 checks passed
@toy toy deleted the opf/bug/73448-closing-the-work-package-split-view-reloads-whole-page-2 branch April 14, 2026 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants