Merged
Conversation
- https://community.openproject.org/work_packages/72971 - added provider link group - added inline wiki page links with empty state - add a counter to notification center tabs - show fake wiki page titles
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
- add lefthook to the npm dev dependencies - this allows executing lefthook even when gems are not installed on the host machine - e.g. important for docker development
Kharonus
commented
Apr 10, 2026
Contributor
NobodysNightmare
left a comment
NobodysNightmare
left a comment
There was a problem hiding this comment.
I'll still have to look at the change from a UI side, but my biggest concern is how we want to render the aggregate number of page links, when that number might not be known to OpenProject from a simple database query.
modules/wikis/app/components/wikis/inline_page_links_component.html.erb
Outdated
Show resolved
Hide resolved
modules/wikis/app/components/wikis/work_package_wikis_tab_component.html.erb
Show resolved
Hide resolved
- emphasize, that counting logic is still incomplete - move wiki locales to module - minor variable renaming
NobodysNightmare
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#72971
What are you trying to accomplish?
What approach did you choose and why?